Skip to content

Implement empty string intrinsic in interpreter#116237

Merged
janvorli merged 1 commit into
dotnet:mainfrom
janvorli:empty-string-intrinsic
Jun 3, 2025
Merged

Implement empty string intrinsic in interpreter#116237
janvorli merged 1 commit into
dotnet:mainfrom
janvorli:empty-string-intrinsic

Conversation

@janvorli

@janvorli janvorli commented Jun 2, 2025

Copy link
Copy Markdown
Member

This change adds support for empty strings

This change adds support for empty strings
@janvorli janvorli added this to the 10.0.0 milestone Jun 2, 2025
@janvorli janvorli self-assigned this Jun 2, 2025
Copilot AI review requested due to automatic review settings June 2, 2025 23:05
@janvorli
janvorli requested review from BrzVlad and kg as code owners June 2, 2025 23:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for an empty string intrinsic in the interpreter.

  • Added a new case for CORINFO_FIELD_INTRINSIC_EMPTY_STRING in the interpreter compiler
  • Inserts instructions to load the empty string literal pointer and push its corresponding data item index

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 2, 2025
@janvorli

janvorli commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

/ba-g #116261

@janvorli
janvorli merged commit 9d1d2a9 into dotnet:main Jun 3, 2025
@janvorli
janvorli deleted the empty-string-intrinsic branch June 3, 2025 14:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants