JIT: Avoid VN-based removal of dead byref store in async funcs#116136
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced May 30, 2025
jakobbotsch
marked this pull request as ready for review
May 30, 2025 20:23
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents the VN-based dead-store removal phase from incorrectly removing stores to byref or GC-byref locals in async methods, addressing issue #116090.
- Adds a check to skip dead-store removal for byref or GC-byref locals when compiling an async method.
- Ensures that stores crossing suspension points are preserved.
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
Member
Author
|
Ping @EgorBo |
EgorBo
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #116090