-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[RuntimeAsync] Disable building async tests on configurations that are not yet supported. #116084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a conditional DisableProjectBuild setting to skip building async tests on configurations (mono, nativeaot, wasm) that aren’t yet supported.
- Introduce a new
<PropertyGroup>with aDisableProjectBuildconditioned onRuntimeFlavor,TestBuildMode, orTargetArchitecture. - Retain the existing unconditional
DisableProjectBuildfor overall runtime async NYI.
Comments suppressed due to low confidence (1)
src/tests/async/Directory.Build.targets:9
- The unconditional
<DisableProjectBuild>in the secondPropertyGroupwill override the conditional property above, effectively disabling builds for all configurations. Consider merging these into onePropertyGroupwith an appropriate condition or removing the unconditional flag so supported configurations can build.
<DisableProjectBuild>true</DisableProjectBuild>
|
The reason why we cannot just exclude the tests from running is because in some cases just trying to build is enough to cause failures as the post-build tooling may not be familiar with runtime async patterns. For an example on how I think it makes sense to not even build these tests on configs where we do not yet expect them to work. |
|
Tagging subscribers to this area: @mangod9 |
agocke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
/ba-g two failures in threading and loader look like known and unrelated. |
Test-only change to disable building async tests on configurations that are not yet supported.