Skip to content

JIT: Fix possible heap corruption in outlined composite SSA storage #116071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

JIT: Fix possible heap corruption in outlined composite SSA storage #116071

merged 1 commit into from
May 30, 2025

Conversation

jakobbotsch
Copy link
Member

Fix #115515

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 14:21
Copilot
Copilot AI reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a potential heap corruption issue in the SSA storage outlining logic by ensuring the loop only iterates over the actual number of slots.

  • Adjust the loop bound from a fixed SIMPLE_NUM_COUNT to the dynamic count value.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 28, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request May 28, 2025
Closed
@jakobbotsch
Copy link
Member Author

PTAL @dotnet/jit-contrib

@jakobbotsch jakobbotsch requested a review from a team May 28, 2025 18:23
@jakobbotsch jakobbotsch merged commit a8bc637 into dotnet:main May 30, 2025
108 of 110 checks passed
@jakobbotsch
Copy link
Member Author

/backport to release/9.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15343922389

@github-actions github-actions bot mentioned this pull request May 30, 2025
Merged
4 tasks
@jakobbotsch jakobbotsch deleted the fix-ssa-composite-heap-overflow branch May 30, 2025 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault (SIGSEGV) libclrjit.so`GenTreeVisitor
2 participants
@jakobbotsch @AndyAyersMS