Skip to content

[Testing only] Ignore #116064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 11:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is a testing-only change that disables a condition check in the EETypeNode dependency analysis.

  • Commented out the if-statement that verifies if CreationAllowed for the type.

@@ -661,7 +661,7 @@ protected override DependencyList ComputeNonRelocationBasedDependencies(NodeFact
}
}

if (!ConstructedEETypeNode.CreationAllowed(_type))
//if (!ConstructedEETypeNode.CreationAllowed(_type))
Copy link
Preview

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the CreationAllowed check may lead to unintended behavior if left in production. If this change is temporary for testing, please add an explanatory comment indicating its purpose and plan for re-enabling the check.

Suggested change
//if (!ConstructedEETypeNode.CreationAllowed(_type))
if (!ConstructedEETypeNode.CreationAllowed(_type))

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky MichalStrehovsky deleted the mdtest branch May 29, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant