-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Android] Re-enable native symbol stripping in the release build of the sample app #116061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Re-enable native symbol stripping in the release build of the sample app #116061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables native symbol stripping in the release build for the Android sample app to address a size on disk regression.
- Re-adds the property in the AndroidSampleApp.csproj file for Release configurations.
Tagging subscribers to this area: @hoyosjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Have you tried running the startup/size measurements to see what the impact is?
Yes, I confirmed locally that the size reverts to its previous values. |
Both SOD and startup have been reverted to their previous values. |
Nice, I suspect that the additional size caused that slow-down in startup due to the design of AndroidSampleApp runtime/src/tasks/AndroidAppBuilder/Templates/MonoRunner.java Lines 147 to 180 in d960be8
I remember we saw really big difference in release vs debug in the initial measurements caused by this section of the code. |
Description
This PR fixes size on disk regression introduced in #114148.