Revert removal of embedModuleHandle and embedFieldHandle #116036
+351
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map (dotnet#115542)" This reverts commit 30160aa.
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the removal of the embedModuleHandle and embedFieldHandle APIs, restoring their implementations in the JIT interface and related components.
- Reintroduces embedModuleHandle and embedFieldHandle method implementations in the VM, SuperPMI, and JIT interface layers.
- Updates the corresponding headers, thunk generation files, and runtime structures to include the restored APIs.
- Adjusts debug and logging functions to capture calls to the restored functions.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/jitinterface.cpp | Adds implementations for embedModuleHandle and embedFieldHandle in CEEInfo. |
| src/coreclr/tools/superpmi/* | Updates in various SuperPMI shim and generated files to forward/embed the restored functions. |
| src/coreclr/tools/Common/JitInterface/* | Adjustments in generated headers and thunk input to reflect the reintroduced functions. |
| src/coreclr/jit/* | Updates in importer.cpp and compiler.hpp to handle the new helper argument type CORINFO_HELPER_ARG_TYPE_Module and invoke the restored functions. |
| src/coreclr/inc/* | Updates in corinfo.h and related generated headers to include the new virtual declarations. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Context #115542 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to keep the abstraction, cc @jkotas