Skip to content

Fix intermittent failures in PAL tests #115958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 1 commit into from
May 26, 2025
Merged

Fix intermittent failures in PAL tests #115958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/coreclr/pal/tests/palsuite/threading/Sleep/test1/Sleep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ PALTEST(threading_Sleep_test1_paltest_sleep_test1, "threading/Sleep/test1/paltes

for( i = 0; i < sizeof(SleepTimes) / sizeof(DWORD); i++)
{
OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
Sleep(SleepTimes[i]);
NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();

TimeDelta = NewTimeStamp - OldTimeStamp;
TimeDelta = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

/* For longer intervals use a 10 percent tolerance */
if ((SleepTimes[i] * 0.1) > AcceptableTimeError)
Expand Down
6 changes: 3 additions & 3 deletions src/coreclr/pal/tests/palsuite/threading/Sleep/test2/sleep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ PALTEST(threading_Sleep_test2_paltest_sleep_test2, "threading/Sleep/test2/paltes

for( i = 0; i < sizeof(SleepTimes) / sizeof(DWORD); i++)
{
OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
Sleep(SleepTimes[i]);
NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();

TimeDelta = NewTimeStamp - OldTimeStamp;
TimeDelta = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

MaxDelta = SleepTimes[i] + AcceptableTimeError;

Expand Down
6 changes: 3 additions & 3 deletions src/coreclr/pal/tests/palsuite/threading/SleepEx/test1/test1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ PALTEST(threading_SleepEx_test1_paltest_sleepex_test1, "threading/SleepEx/test1/

for (i = 0; i<sizeof(testCases) / sizeof(testCases[0]); i++)
{
OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();

SleepEx(testCases[i].SleepTime, testCases[i].Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();

TimeDelta = NewTimeStamp - OldTimeStamp;
TimeDelta = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

/* For longer intervals use a 10 percent tolerance */
if ((testCases[i].SleepTime * 0.1) > AcceptableTimeError)
Expand Down
6 changes: 3 additions & 3 deletions src/coreclr/pal/tests/palsuite/threading/SleepEx/test2/test2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,12 @@ DWORD PALAPI SleeperProc_SleepEx_test2(LPVOID lpParameter)

Alertable = (BOOL)(SIZE_T) lpParameter;

OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
s_preWaitTimestampRecorded = true;

ret = SleepEx(ChildThreadSleepTime, Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();

if (Alertable && ret != WAIT_IO_COMPLETION)
{
Expand All @@ -180,7 +180,7 @@ DWORD PALAPI SleeperProc_SleepEx_test2(LPVOID lpParameter)
}


ThreadSleepDelta = NewTimeStamp - OldTimeStamp;
ThreadSleepDelta = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

return 0;
}
6 changes: 3 additions & 3 deletions src/coreclr/pal/tests/palsuite/threading/WaitForMultipleObjectsEx/test2/test2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,13 @@ DWORD PALAPI WaiterProc_WFMO_test2(LPVOID lpParameter)

Alertable = (BOOL)(SIZE_T) lpParameter;

OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
s_preWaitTimestampRecorded = true;

ret = WaitForMultipleObjectsEx(1, &Semaphore, FALSE, ChildThreadWaitTime,
Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();


if (Alertable && ret != WAIT_IO_COMPLETION)
Expand All @@ -176,7 +176,7 @@ DWORD PALAPI WaiterProc_WFMO_test2(LPVOID lpParameter)
"Expected return of WAIT_TIMEOUT, got %d.\n", ret);
}

ThreadWaitDelta_WFMO_test2 = NewTimeStamp - OldTimeStamp;
ThreadWaitDelta_WFMO_test2 = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

ret = CloseHandle(Semaphore);
if (!ret)
Expand Down
6 changes: 3 additions & 3 deletions ...eclr/pal/tests/palsuite/threading/WaitForSingleObject/WFSOExMutexTest/WFSOExMutexTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,14 @@ DWORD PALAPI WaiterProc_WFSOExMutexTest(LPVOID lpParameter)

Alertable = (BOOL)(SIZE_T) lpParameter;

OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
s_preWaitTimestampRecorded = true;

ret = WaitForSingleObjectEx( hMutex_WFSOExMutexTest,
ChildThreadWaitTime,
Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();

if (Alertable && ret != WAIT_IO_COMPLETION)
{
Expand All @@ -204,7 +204,7 @@ DWORD PALAPI WaiterProc_WFSOExMutexTest(LPVOID lpParameter)
"Expected return of WAIT_TIMEOUT, got %d.\n", ret);
}

ThreadWaitDelta_WFSOExMutexTest = NewTimeStamp - OldTimeStamp;
ThreadWaitDelta_WFSOExMutexTest = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

return 0;
}
Expand Down
6 changes: 3 additions & 3 deletions .../tests/palsuite/threading/WaitForSingleObject/WFSOExSemaphoreTest/WFSOExSemaphoreTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,14 @@ DWORD PALAPI WaiterProc_WFSOExSemaphoreTest(LPVOID lpParameter)

Alertable = (BOOL)(SIZE_T) lpParameter;

OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
s_preWaitTimestampRecorded = true;

ret = WaitForSingleObjectEx( hSemaphore,
ChildThreadWaitTime,
Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();


if (Alertable && ret != WAIT_IO_COMPLETION)
Expand All @@ -171,7 +171,7 @@ DWORD PALAPI WaiterProc_WFSOExSemaphoreTest(LPVOID lpParameter)
}


ThreadWaitDelta_WFSOExSemaphoreTest = NewTimeStamp - OldTimeStamp;
ThreadWaitDelta_WFSOExSemaphoreTest = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

ret = CloseHandle(hSemaphore);
if (!ret)
Expand Down
6 changes: 3 additions & 3 deletions ...lr/pal/tests/palsuite/threading/WaitForSingleObject/WFSOExThreadTest/WFSOExThreadTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,14 @@ satisfying any threads that were waiting on the object.

Alertable = (BOOL)(SIZE_T) lpParameter;

OldTimeStamp = minipal_lowres_ticks();
OldTimeStamp = minipal_hires_ticks();
s_preWaitTimestampRecorded = true;

ret = WaitForSingleObjectEx( hWaitThread,
ChildThreadWaitTime,
Alertable);

NewTimeStamp = minipal_lowres_ticks();
NewTimeStamp = minipal_hires_ticks();


if (Alertable && ret != WAIT_IO_COMPLETION)
Expand All @@ -184,7 +184,7 @@ satisfying any threads that were waiting on the object.
"Expected return of WAIT_TIMEOUT, got %d.\n", ret);
}

ThreadWaitDelta_WFSOExThreadTest = NewTimeStamp - OldTimeStamp;
ThreadWaitDelta_WFSOExThreadTest = (NewTimeStamp - OldTimeStamp) / (minipal_hires_tick_frequency() / 1000);;
Comment thread
jkotas marked this conversation as resolved.

ret = CloseHandle(hWaitThread);
if (!ret)
Expand Down