Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented May 23, 2025

Delete unnecessary version check

Delete unnecessary version check
Copilot AI review requested due to automatic review settings May 23, 2025 19:26
@jkotas jkotas requested a review from MichalStrehovsky as a code owner May 23, 2025 19:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the findvcvarsall.bat script by removing the version constraint on the Visual Studio tools lookup.

  • Deleted the -version [16,18^) filter in the vswhere invocation.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested a review from jkoritzinsky May 23, 2025 19:28
@jkotas
Copy link
Member Author

jkotas commented May 24, 2025

/ba-g known issue #115955

@jkotas jkotas merged commit c00b15f into dotnet:main May 24, 2025
90 of 93 checks passed
@jkotas jkotas deleted the simplify branch May 24, 2025 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
@agocke
Copy link
Member

agocke commented Oct 20, 2025

/backport to release/9.0-staging

@agocke
Copy link
Member

agocke commented Oct 20, 2025

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation Oct 20, 2025
@github-actions
Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18660585515

@github-actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18660588581

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2025
FOR /F "tokens=*" %%i IN (
'"%vswherePath%" -latest -prerelease -products * ^
-requires Microsoft.VisualStudio.Component.VC.Tools.%toolsSuffix% ^
-version [16^,18^) ^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkotas We are updating to VS2026 images in microsoft/testfx#6864 and we are seeing error messages like:

D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\8J7t2\.packages\microsoft.dotnet.ilcompiler\9.0.10\build\Microsoft.NETCore.Native.Windows.targets(138,5): error : Platform linker not found. Ensure you have all the required prerequisites documented at https://aka.ms/nativeaot-prerequisites, in particular the Desktop Development for C++ workload in Visual Studio. For ARM64 development also install C++ ARM64 build tools. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\WgXqn\MSTestSdk\MSTestSdk.csproj::TargetFramework=net9.0]

I think it is caused by this version check. Was this backported to .NET 9 successfully? Will we have a fixed Microsoft.DotNet.ILCompiler soon? (e.g, 9.0.11?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It merged into 9.0 today: #120913

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichalStrehovsky When will it be published on nuget.org and flows to SDK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is December release. .NET 10 doesn't have the bug if upgrading the project to net10.0 is an option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants