-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Simplify findvcvarsall.bat #115951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify findvcvarsall.bat #115951
Conversation
Delete unnecessary version check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the findvcvarsall.bat script by removing the version constraint on the Visual Studio tools lookup.
- Deleted the
-version [16,18^)filter in thevswhereinvocation.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
/ba-g known issue #115955 |
|
/backport to release/9.0-staging |
|
/backport to release/8.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18660585515 |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/18660588581 |
| FOR /F "tokens=*" %%i IN ( | ||
| '"%vswherePath%" -latest -prerelease -products * ^ | ||
| -requires Microsoft.VisualStudio.Component.VC.Tools.%toolsSuffix% ^ | ||
| -version [16^,18^) ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkotas We are updating to VS2026 images in microsoft/testfx#6864 and we are seeing error messages like:
D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\8J7t2\.packages\microsoft.dotnet.ilcompiler\9.0.10\build\Microsoft.NETCore.Native.Windows.targets(138,5): error : Platform linker not found. Ensure you have all the required prerequisites documented at https://aka.ms/nativeaot-prerequisites, in particular the Desktop Development for C++ workload in Visual Studio. For ARM64 development also install C++ ARM64 build tools. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\WgXqn\MSTestSdk\MSTestSdk.csproj::TargetFramework=net9.0]
I think it is caused by this version check. Was this backported to .NET 9 successfully? Will we have a fixed Microsoft.DotNet.ILCompiler soon? (e.g, 9.0.11?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It merged into 9.0 today: #120913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalStrehovsky When will it be published on nuget.org and flows to SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is December release. .NET 10 doesn't have the bug if upgrading the project to net10.0 is an option.
Delete unnecessary version check