JIT: Remove overzealous async assert #115883
Open
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The store can come from a `STORE_LCL_FLD`, so in reality there is no relation between the type of the resultLcl and the call type. The code below handles `STORE_LCL_FLD` correctly, so just remove the assert.
There was a problem hiding this comment.
Pull Request Overview
This PR removes an overzealous assert in the async transformation logic that mistakenly assumes the structure type of the result local variable matches the call’s return type, even when the store originates from a STORE_LCL_FLD.
- Removed a redundant assert in async.cpp
- Clarified handling of STORE_LCL_FLD scenarios to prevent incorrect assumptions
Comments suppressed due to low confidence (1)
src/coreclr/jit/async.cpp:1540
- Consider adding a brief comment here to explain why this assertion was removed, particularly highlighting that STORE_LCL_FLD may yield a different relation between result local type and call return type.
assert(varTypeIsStruct(resultLcl) == varTypeIsStruct(call->gtReturnType));
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @dotnet/jit-contrib |
amanasifkhalid
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store can come from a
STORE_LCL_FLD, so in reality there is no relation between the type of the resultLcl and the call type. The code below handlesSTORE_LCL_FLDcorrectly, so just remove the assert.Fix #115839