Remove unwanted ternary node in lowering #115584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalspathak
changed the title
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #115488 by removing an unwanted ternary node during the JIT lowering phase. Key changes include:
- Adding a regression test project and source file to exercise the affected hardware intrinsic logic.
- Modifying the lowering logic in lowerxarch.cpp to remove unnecessary nodes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/JIT/Regression/JitBlue/Runtime_115488.csproj | New test project file to build the regression case |
| src/tests/JIT/Regression/JitBlue/Runtime_115488.cs | New test case invoking Avx512F.TernaryLogic to reproduce the issue |
| src/coreclr/jit/lowerxarch.cpp | Updated lowering logic: removed unused nodes to fix the ternary node issue |
Comments suppressed due to low confidence (1)
src/coreclr/jit/lowerxarch.cpp:4130
- Verify that removing 'node' and returning 'node->gtNext' maintains the intended control flow without unintended side effects in later phases.
BlockRange().Remove(node);
src/coreclr/jit/lowerxarch.cpp
Outdated
| @@ -4052,6 +4052,7 @@ GenTree* Lowering::LowerHWIntrinsicTernaryLogic(GenTreeHWIntrinsic* node) | |||
| replacementNode = comp->gtNewAllBitsSetConNode(simdType); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining why 'op4' is removed to help future maintainers understand its necessity.
Suggested change
| // Remove op4 as it is not used in this scenario and does not contribute to the result. |
Copilot uses AI. Check for mistakes.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
May 15, 2025
|
superpmi-diff is timing out for tpdiff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #115488