[xharness] use NetCoreAppPrevious for DLLs loaded into xharness by reflection #115563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR revises several project configuration files to ensure that DLLs loaded via reflection in xharness target the correct framework version.
- Changed the target framework from
$(NetCoreAppToolCurrent) or $ (AspNetCoreAppCurrent) to $(NetCoreAppPrevious) in multiple project files. - Updated corresponding file properties and deployment targets to maintain compatibility when loaded into xharness.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mono/wasm/symbolicator/WasmSymbolicator.csproj | Updated target framework and inline comment to reflect use of $(NetCoreAppPrevious) |
| src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/RemoteLoopServer.csproj | Updated target framework and comment for reflection-loaded DLL |
| src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj | Updated target framework and comment for reflection-loaded DLL |
| src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props | Updated property value for target framework for browser/WASI targets |
| eng/testing/tests.wasm.targets | Updated deployment target for WasmSymbolicator.dll to use $(NetCoreAppPrevious) |
akoeplinger
approved these changes
May 14, 2025
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.