JIT: Kill assertions about struct local when skipping field stores in block morph #115556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
jakobbotsch
commented
May 14, 2025
Comment on lines
-245
to
-246
| // Consider doing this for FieldByField as well | ||
| // |
There was a problem hiding this comment.
We already do this for the individual fields in that case. And doing it for the base local is unlikely to help anything since the local should be morphed to its fields.
This was referenced May 14, 2025
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS @EgorBo |
EgorBo
approved these changes
May 14, 2025
AndyAyersMS
approved these changes
May 14, 2025
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15024954839 |
|
@jakobbotsch backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Avoid removing dead field stores if we generated an assertion
Applying: Kill assertions when skipping field stores instead
error: sha1 information is lacking or useless (src/coreclr/jit/morphblock.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Kill assertions when skipping field stores instead
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15025151702 |
|
@jakobbotsch backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Avoid removing dead field stores if we generated an assertion
Applying: Kill assertions when skipping field stores instead
error: sha1 information is lacking or useless (src/coreclr/jit/morphblock.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Kill assertions when skipping field stores instead
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we skip storing a field local because we know it is dead, then assertions about the struct local are no longer valid, so invalidate them in that case.
Without this change we could end up using the assertion about the struct local to remove a future store to the particular field, which would leave no zeroing of that field, and would be observable.
Fix #113658