Skip to content

[RuntimeAsync] Make runtime async tests to build and pass locally. #115499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented May 12, 2025

This change reorganizes moves individual tests into directories and adds missing parts to make the tests buildable.

Also fixes couple issues, that fell through the cracks when VM and JIT portions of the feature merged separately.

With this change async tests can be built and run locally together with other tests with a few steps that enable feature and the tests, and as long as local toolset compiler is patched with one that understands async2 syntax.

We will work on a more streamlined workflow. This is a step in that direction.

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member Author

VSadov commented May 12, 2025

How async tests can now be built and run locally:

  • patch the toolset compiler - basically do buildroslynnugets.bat per runtimelab instructions and copy tasks
    from the Microsoft.Net.Compilers.Toolset.5.0.0-async-16.nupkg (rename to .zip and open)
    to C:\Users\<user>\.nuget\packages\microsoft.net.compilers.toolset\5.0.0-1.25220.1, or whatever version is in use by the build.
  • uncomment add_compile_definitions(FEATURE_RUNTIME_ASYNC) - to enable the feature in the product.
  • delete src\tests\async\Directory.Build.targets - to unblock async tests from building.

Then build/run tests as usual. Tests under async should build, run and pass.

We will work on a simpler workflow and enabling tests in CI (not in regular runs).
This is a step towards that.

@VSadov
Copy link
Member Author

VSadov commented May 13, 2025

Thanks!!

@VSadov VSadov merged commit 9bcd3e7 into dotnet:main May 13, 2025
114 checks passed
@VSadov VSadov deleted the tests1 branch May 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants