Sve: Fix Gather/Scatter tests #115036
Merged
Sve: Fix Gather/Scatter tests #115036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorFirstFaultingVectorBases.template: Language not supported
- src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveGatherVectorVectorBases.template: Language not supported
- src/tests/JIT/HardwareIntrinsics/Arm/Shared/SveScatterVectorBases.template: Language not supported
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib @dotnet/arm64-contrib @a74nh |
|
/azp run runtime-coreclr jitstress, runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Open
3 tasks
a74nh
approved these changes
Apr 25, 2025
BruceForstall
approved these changes
Apr 25, 2025
|
/ba-g outerloop failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVE Gather/Scatter tests populates a data array and then get the addresses of some of the elements of data array. These addresses are then passed to SVE APIs to see if the API correctly loads the required elements and validates the result. The step where we were populating the individual element address has a bug in pointer arithmetic and was returning incorrect address of pointers. When the underlying data is
double, returning invalid aligned data element address would treat the underlying data asNaNor other times, might not match the expected return result from these APIs. I have fixed the pointer arithmetic to correctly calculate the address of the individual element and now the tests are passing as expected. I have also addedDebug.Assert()while setting up the addresses to make sure we are doing it correctly.I also noticed similar problem for Scatter test cases and fixed them too.
Fixes: #114646
Fixes: #112264