Report error if dotnet-pgo trace contains multiple processes #114962
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a logic error. When the trace file has multiple processes and no PID or process name was specified, we're supposed to instruct the user to provide it. Instead, we instruct user to provide it only if `--pid` is actually specified.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic for reporting an error when the trace file contains multiple processes and neither PID nor process name is specified.
- Fixes the incorrect condition for error reporting by checking if PID is not provided.
- Updates the error handling to prompt the user for a PID or process name when multiple processes exist.
Comments suppressed due to low confidence (1)
src/coreclr/tools/dotnet-pgo/Program.cs:1055
- [nitpick] Consider rephrasing the error message for improved clarity. For example, 'Trace file contains multiple processes; please specify either a PID or process name' might provide clearer guidance to the user.
PrintError("Trace file contains multiple processes to distinguish between");
jkotas
approved these changes
Apr 23, 2025
agocke
approved these changes
Apr 23, 2025
jakobbotsch
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic error. When the trace file has multiple processes and no PID or process name was specified, we're supposed to instruct the user to provide it. Instead, we instruct user to provide it only if
--pidis actually specified.