JIT: Escape analysis cleanup #114716
Merged
JIT: Escape analysis cleanup #114716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
| @@ -1449,8 +1444,7 @@ unsigned int ObjectAllocator::MorphNewArrNodeIntoStackAlloc(GenTreeCall* | |||
| // allocation. | |||
| // Arguments: | |||
| // allocObj - GT_ALLOCOBJ that will be replaced by a stack allocation | |||
| // clsHnd - class representing the stack allocated object | |||
| // isValueClass - we are stack allocating a boxed value class | |||
| // layout - layout for the stack allocated objectd | |||
There was a problem hiding this comment.
Typo in the comment: 'objectd' should be corrected to 'object'.
Suggested change
| // layout - layout for the stack allocated objectd | |
| // layout - layout for the stack allocated object |
Copilot uses AI. Check for mistakes.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@jakobbotsch PTAL One diff locally. A boxed object had padding that is now properly modelled during promotion, leading to slightly better code. SPMI misses since we now call |
Open
3 tasks
jakobbotsch
reviewed
Apr 16, 2025
|
|
||
| if (isValueClass) | ||
| { | ||
| CORINFO_CLASS_HANDLE boxedClsHnd = comp->info.compCompHnd->getTypeForBox(clsHnd); |
There was a problem hiding this comment.
Is this purely for correct handling of nullables?
jakobbotsch
approved these changes
Apr 16, 2025
|
Linux x64 failure might be related, let me see if I can repro it. |
|
No luck with runfo bits so far. Going to retry CI. |
This was referenced Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #113977
printfAllocin a few placesAddresses JIT side of #114204 -- I have not altered the VM or jit interface yet, to allow this PR to be easily diffable.