Skip to content

arm64: Additions with GetActiveElementCount() should use incp when given the same predicate #114628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

arm64: Additions with GetActiveElementCount() should use incp when given the same predicate #114628

wants to merge 3 commits into from
+139 −1

Conversation

jonathandavies-arm
Copy link
Contributor

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 14, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 14, 2025
@jonathandavies-arm
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Apr 25, 2025
@kunalspathak kunalspathak self-requested a review April 25, 2025 22:03
@kunalspathak
Copy link
Member

@jonathandavies-arm - can you fix the build errors?

  D:\a\_work\1\s\src\coreclr\jit\lower.cpp(7211) : error C4701: potentially uninitialized local variable 'next' used

kunalspathak
kunalspathak reviewed Apr 25, 2025
View reviewed changes
src/coreclr/jit/lowerarmarch.cpp
const GenTreeHWIntrinsic* elementCountNode = op1->AsHWIntrinsic();
GenTree* mask1 = elementCountNode->Op(1)->AsHWIntrinsic()->Op(2);
GenTree* mask2 = elementCountNode->Op(2)->AsHWIntrinsic()->Op(2);
if (mask1->GetVN(VNK_Liberal) != mask2->GetVN(VNK_Liberal))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here we are using value numbering to contain the node, which seems wrong. This should ideally be happening in VN/CSE. Did you check why that is not happening?

This was referenced Apr 26, 2025
Open
Open
@kunalspathak kunalspathak added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 13, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunalspathak kunalspathak kunalspathak left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARM64-SVE: Additions with GetActiveElementCount() should use incp
2 participants
@jonathandavies-arm @kunalspathak