-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[LoongArch64] Fix ld.lld relocation 'R_LARCH_PCALA_LO12' error when building NativeAOT testcases. #114616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uilding NAOT testcases.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
This commit fixed the building of NAOT smoke tests which is mentioned in #104661 (comment) :
The ld.bfd should report errors when linking illegal symbol, but it doesn't, we have reported this to the LD team. |
|
Hi @shushanhf @jakobbotsch , could you please review this PR? Thanks. |
|
Nice!
My takeaway from reading a few posts on https://maskray.me/blog/, there's no perfect linker; it's a balance between best effort to unblock people and nitpicking on what constitutes illegal. So it pays to collect diagnostics from both lld and bfd (and if feasible, gold and mold too) and aim to make all of them happy. 😅 |
shushanhf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
|
Hi @jakobbotsch @jkotas could you please help to review this PR? Thanks. |
|
/ba-g DeadLetter |
Fix the build error of the NativeAOT smoke tests which is mentioned in #104661 (comment)