Fix contract violations for OLE scenario.

[AaronRobinsonMSFT]

Rework the logic so the FCall doesn't do any
allocations and defers any non-fast scenario
to the slow path.

Fixes #114372

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/coreclr/vm/stubhelpers.cpp:194

• [nitpick] Consider adding a clarifying comment that explains TryGetOleTlsData only retrieves existing TLS data without creating it, to differentiate it clearly from GetOrCreateOleTlsData.

FORCEINLINE static SOleTlsData* TryGetOleTlsData()

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/coreclr/vm/stubhelpers.cpp:232

• The removal of the FP state clearing call in the slow path diverges from the previous behavior where FP state was cleared for VB6 compatibility. Verify that this change is intentional and that it does not introduce issues in scenarios requiring FP state clearing.

GetCOMIPFromRCW_ClearFP();

src/coreclr/vm/olecontexthelpers.cpp:37

• Switching the contract mode from MODE_ANY (with ENTRY_POINT) to MODE_COOPERATIVE may affect call sites that previously relied on a more flexible mode. Confirm that this change is appropriate for all scenarios where SetupOleContext is used.

MODE_COOPERATIVE;

[AaronRobinsonMSFT]

/cc @jkoritzinsky