Skip to content

[wasm][interp] Add Round alias #114399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

[wasm][interp] Add Round alias #114399

merged 2 commits into from
Apr 9, 2025

Conversation

lewing
Copy link
Member

@lewing lewing commented Apr 8, 2025

And see if the tests are happy

@lewing lewing marked this pull request as ready for review April 8, 2025 19:15
@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 19:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/mono/mono/mini/interp/simd-methods.def: Language not supported
Comments suppressed due to low confidence (1)

src/mono/mono/mini/interp/transform-simd.c:1171

  • Please add or update tests to cover the new SN_Round alias functionality in the SIMD transformation logic.
case SN_Round:

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@lewing lewing requested review from kg and radekdoulik April 8, 2025 21:11
@kg
Copy link
Member

kg commented Apr 8, 2025

Make sure you handle the Round overload that takes a rounding mode
https://learn.microsoft.com/en-us/dotnet/api/system.runtime.intrinsics.vector128.round

@lewing
Copy link
Member Author

lewing commented Apr 8, 2025

I added a check that will work for the current case. While this should be good enough for the moment if we continue to do work here it would make sense to improve the lookup validation (it was also wrong for actual PackedSimd methods #114413)

@lewing
Copy link
Member Author

lewing commented Apr 9, 2025

The failures were known but I kicked off a rebuild just to clear the EAT lane than timed out

@lewing lewing merged commit 92b81d9 into dotnet:main Apr 9, 2025
68 of 70 checks passed
@lewing lewing deleted the round-up branch April 9, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants