-
Notifications
You must be signed in to change notification settings - Fork 5k
[wasm][interp] Add Round alias #114399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][interp] Add Round alias #114399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/mono/mono/mini/interp/simd-methods.def: Language not supported
Comments suppressed due to low confidence (1)
src/mono/mono/mini/interp/transform-simd.c:1171
- Please add or update tests to cover the new SN_Round alias functionality in the SIMD transformation logic.
case SN_Round:
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
Make sure you handle the Round overload that takes a rounding mode |
I added a check that will work for the current case. While this should be good enough for the moment if we continue to do work here it would make sense to improve the lookup validation (it was also wrong for actual PackedSimd methods #114413) |
The failures were known but I kicked off a rebuild just to clear the EAT lane than timed out |
And see if the tests are happy