-
Notifications
You must be signed in to change notification settings - Fork 5k
[riscv] Fix build break of riscv #114394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[riscv] Fix build break of riscv #114394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@dotnet/jit-contrib - superpmi-diffs pipeline is broken because of this. |
RISC-V Release-CLR-VF2: 9532 / 9552 (99.79%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9532 / 9552 (99.79%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-QEMU: 635792 / 663752 (95.79%)
Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz Build information and commandsGIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
fyi, this shouldn't happen again: the addition of the community JITs build to superpmi-diffs happened after the PR that introduced this failure was tested (including running superpmi-diffs). |
Yes, please merge main to the existing arch-riscv PR branches to find out potential issues with MSVC / windows builds. |
Fix build break introduced in #114337
cc: @tomeksowi