-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Send host tests to helix #114187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send host tests to helix #114187
Conversation
/azp run runtime |
Azure Pipelines failed to run 1 pipeline(s). |
34ff3b5
to
ae7e9ff
Compare
fb99271
to
246c9d9
Compare
parameters: | ||
DisplayNamePrefix: Send to Helix | ||
HelixProjectPath: src/installer/tests/helixpublish.proj | ||
HelixProjectArguments: /p:Configuration=${{ parameters.buildConfig }} /p:TargetArchitecture=${{ parameters.archType }} /p:TargetRuntimeIdentifier=${{ parameters.targetRid }} /p:TargetOS=${{ parameters.osGroup }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, if we remove TargetRuntimeIdentifier
from here, would it default to OutputRID as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think the host tests always use OutputRID
, so TargetRuntimeIdentifier
is not needed/used (and this is just from using the arguments from libraries tests as reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this note, I think targetRid
(which gets passed to builds as p:TargetRid
) shouldn't be needed in eng/pipelines/*
in principle as in the code, we compute the OutputRID; except for NonexistentRID
(banana.24-x64
dummy RID test leg which is failing for several months) and CentOS9
(centos.9-x64
which is a non-portable RID).
57d53c9
to
983c96a
Compare
30d9c38
to
65728d9
Compare
65728d9
to
2705d22
Compare
2705d22
to
2051a3d
Compare
The packaging tests should really live in Arcade as part of testing the SharedFramework SDK. |
Opened #115522 about moving the packaging tests. |
Update installer pipelines to send host tests to helix instead of running locally
host-<os>-<arch> @ <helix_queue>
This change only handles platforms that we were already running tests on (linux_x64, osx_x64, windown_x64, windows_x86). We would want further updates to add other platforms (for example, arm64, linux_musl).
This does remove running of
Microsoft.DotNet.CoreSetup.Packaging.Tests
tests in PR/CI. I don't think those are particularly useful at this point - I've haven't seen them fail and find an issue in my time here,Test updates:
Contributes to #77800
cc @dotnet/appmodel