Skip to content

Pin the System.Memory package reference version in Microsoft.Extensions.DependencyModel #114173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Pin the System.Memory package reference version in Microsoft.Extensions.DependencyModel #114173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
979bdb6
Pin the System.Memory package reference version in Microsoft.Extensio…
carlossanlop Apr 2, 2025
f74cabc
Switch to toolset versions and packages instead of projects
carlossanlop Apr 2, 2025
42c918e
Only add package reference when not building for compatible toolset f…
ericstj Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@
<SystemThreadingAccessControlVersion>7.0.0</SystemThreadingAccessControlVersion>
<runtimenativeSystemIOPortsVersion>10.0.0-preview.3.25152.4</runtimenativeSystemIOPortsVersion>
<!-- Keep toolset versions in sync with dotnet/msbuild and dotnet/sdk -->
<!-- The framework targeted by and package release band for the minimum toolset version our tasks must support -->
<ToolsetTargetFramework>net8.0</ToolsetTargetFramework>
Comment on lines +141 to +142
Copy link
Member

@ViktorHofer ViktorHofer Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially NetToolMinimum: https://github.com/dotnet/arcade/blob/63c161539bde4a68f27bc66598137da578331d85/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkDefaults.props#L37-L40

We added the NetTool* properties for the VS constraint.

Copy link
Member

@ericstj ericstj Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if we already had it somewhere. Let's hold off on changing this PR and burning more build resources until we understand what direction we want to take. I'm not sure if this one is going to pan out.

<MicrosoftBclAsyncInterfacesToolsetVersion>8.0.0</MicrosoftBclAsyncInterfacesToolsetVersion>
<SystemBuffersToolsetVersion>4.5.1</SystemBuffersToolsetVersion>
<SystemCollectionsImmutableToolsetVersion>8.0.0</SystemCollectionsImmutableToolsetVersion>
Expand Down
10 changes: 5 additions & 5 deletions ...ries/Microsoft.Extensions.DependencyModel/src/Microsoft.Extensions.DependencyModel.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ By default, the dependency manifest contains information about the application's
<InternalsVisibleTo Include="Microsoft.Extensions.DependencyModel.Tests" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != '$(NetCoreAppCurrent)'">
<ProjectReference Include="$(LibrariesProjectRoot)System.Text.Encodings.Web\src\System.Text.Encodings.Web.csproj" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Text.Json\src\System.Text.Json.csproj" />
<ItemGroup Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', '$(ToolsetTargetFramework)'))">
<PackageReference Include="System.Text.Encodings.Web" Version="$(SystemTextEncodingsWebToolsetVersion)" />
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonToolsetVersion)" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
<PackageReference Include="System.Buffers" Version="$(SystemBuffersVersion)" />
<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
<PackageReference Include="System.Buffers" Version="$(SystemBuffersToolsetVersion)" />
<PackageReference Include="System.Memory" Version="$(SystemMemoryToolsetVersion)" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
Expand Down
Loading