Rename rapidjson helper functions #114017
Open
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- src/native/corehost/comhost/clsidmap.cpp: Language not supported
- src/native/corehost/fxr/sdk_resolver.cpp: Language not supported
- src/native/corehost/fxr/standalone/hostpolicy_resolver.cpp: Language not supported
- src/native/corehost/hostpolicy/deps_format.cpp: Language not supported
- src/native/corehost/json_parser.cpp: Language not supported
- src/native/corehost/json_parser.h: Language not supported
- src/native/corehost/runtime_config.cpp: Language not supported
ghost
added
the
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
GrabYourPitchforks
force-pushed
the
rapidjson
branch
from
cd59749 to
b1f578c
Compare
|
Rebased on latest main to resolve merge conflicts. |
|
We could also consider switching to https://github.com/simdjson/simdjson. |
This was referenced Mar 29, 2025
This was referenced Mar 29, 2025
|
FWIW, here is the initial impl. main...am11:runtime:feature/corehost/simdjson (windows would require UTF-16/8 conversion as happens with rapidjson's non-insitu mode behind the scenes) It's a size regression (which I'm not sure matters in read-world with corehost variants):
|
This was referenced Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rapidjson is a disallowed deserializer within Microsoft, signing off on .NET 10 will require us to attest that every call site into rapidjson processes only fully trusted input.
This is straightforward enough for a point-in-time assessment, but it does represent ongoing cost, and we don't want to risk introducing new call sites into this logic where we can't guarantee that the input is trustworthy. To facilitate this, I recommend renaming our rapidjson wrapping utility methods to
parse_fully_trusted_raw_dataandparse_fully_trusted_file, which clearly indicate at the invocation site that the caller passes only fully trustworthy data. This should reduce the risk of us violating the trust contract going forward and should simplify future attestations.(Jeff, this is what I pinged you about via IM.)