Only use PGO data if clang can read it #114005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #34649 and fixes the Codespaces prebuild.
ghost
added
the
am11
reviewed
Mar 28, 2025
This was referenced Mar 28, 2025
akoeplinger
changed the title
am11
reviewed
Mar 28, 2025
| message(WARNING "PGO is not supported; Clang 16 or later is required for profile guided optimizations") | ||
| endif((CMAKE_CXX_COMPILER_ID MATCHES "Clang") AND (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 16)) | ||
| else(HAVE_LTO_AND_PGO_DATA_SUPPORTED) | ||
| message(WARNING "LTO is not supported or PGO optimization data not compatible, skipping profile guided optimizations for ${TargetName}") |
There was a problem hiding this comment.
If we pass msbuild's OfficialBuildId != '' to cmake as CLR_IS_OFFICIAL_BUILD e.g., then we can use it to error out to make the problem visible (probably we don't want it to slip through unnoticed).
There was a problem hiding this comment.
good idea, but that is also set for source-build and afaik they can't use our PGO packages so we shouldn't error in that case. I'd do that in a separate PR.
|
/ba-g azurelinux timeouts are unrelated |
LoopedBard3
approved these changes
Mar 28, 2025
thaystg
pushed a commit
to thaystg/runtime
that referenced
this pull request
Apr 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Codespaces prebuild.
Fixes #34649