Unify the JsonDocument and Utf8JsonReader handling of DateTime/Offset#113929
Merged
Conversation
Since so much of the code is identical, move it to JsonReaderHelper Closes dotnet#28931
ghost
added
the
dotnet-policy-service
Bot
added
the
community-contribution
This was referenced Mar 26, 2025
PranavSenthilnathan
self-requested a review
May 26, 2025 08:54
PranavSenthilnathan
approved these changes
May 27, 2025
Member
|
Thanks |
mwadams
added a commit
to mwadams/Corvus.Text.Json
that referenced
this pull request
Jun 22, 2025
Also extend to the other date/time/period types from NodaTime that we support in the same direct way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since so much of the code is identical, move it to
JsonReaderHelperand call into it fromJsonDocument.csandUtf8JsonReader.TryGet.csCloses #28931