Build Mono's Framework libs in unified builds #113897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2025
akoeplinger
approved these changes
Mar 26, 2025
|
/ba-g failures are on coreclr so unrelated to the mono changes |
ViktorHofer
reviewed
Mar 26, 2025
| @@ -122,6 +122,8 @@ | |||
| <InnerBuildArgs Condition="'$(NetCoreAppToolCurrentVersion)' != ''">$(InnerBuildArgs) /p:NetCoreAppToolCurrentVersion=$(NetCoreAppToolCurrentVersion)</InnerBuildArgs> | |||
|
|
|||
| <InnerBuildArgs Condition="'$(EnableDefaultRidSpecificArtifacts)' != ''">$(InnerBuildArgs) /p:EnableDefaultRidSpecificArtifacts=$(EnableDefaultRidSpecificArtifacts)</InnerBuildArgs> | |||
|
|
|||
| <InnerBuildArgs Condition="'$(TargetOS)' == 'ios' or '$(TargetOS)' == 'maccatalyst' or '$(TargetOS)' == 'tvos'">$(InnerBuildArgs) /p:BuildDarwinFrameworks=true</InnerBuildArgs> | |||
There was a problem hiding this comment.
I don't have any context on this property. Can someone please explain why this isn't the default when targeting these OSs?
There was a problem hiding this comment.
that's a great question actually, looks like Zoltan asked for this in #53370 (comment) but I don't see a reason why it needs to be a flag still, the build perf impact for local builds should be negligible.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Mar 26, 2025
Remove the BuildDarwinFrameworks option. Follow-up to dotnet#113897 (comment)
akoeplinger
added a commit
that referenced
this pull request
Mar 26, 2025
Remove the BuildDarwinFrameworks option. Follow-up to #113897 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4945