Target NetFrameworkCurrent in tests and remove old mentions #113667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
... of previous .NET Framework versions in docs / tests. NetFrameworkMinimum (net462) -> NetFrameworkCurrent (net481) so that we can start consuming xunit v3 which requires at least net472. Use NetFrameworkCurrent as the actual runtime that is then used is .NET Framework 4.8.1 anyway (innerloop & CI).
ViktorHofer
force-pushed
the
TargetNetFrameworkCurrentInTests
branch
from
8c4ea75 to
4b0bb89
Compare
This was referenced Mar 18, 2025
3 tasks
Member
Author
|
@akoeplinger PTAL |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the target .NET Framework version from net48 to net481 in pipelines, tests, and documentation to meet the requirements for consuming xUnit v3.
- Updates condition checks and build arguments across pipeline YAML files.
- Updates documentation to reflect the new framework version.
Reviewed Changes
Copilot reviewed 121 out of 135 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Changed framework condition checks and references |
| eng/pipelines/libraries/outerloop.yml | Updated framework values and build arguments |
| docs/coding-guidelines/project-guidelines.md | Updated supported .NET Framework version |
| eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml | Updated framework-related parameters in pipeline configuration |
| eng/pipelines/runtime.yml | Updated framework-related parameters in build configuration |
| docs/workflow/building/libraries/README.md | Updated documentation for .NET Framework version |
Files not reviewed (14)
- Directory.Build.props: Language not supported
- eng/build.ps1: Language not supported
- eng/build.sh: Language not supported
- src/libraries/Common/tests/TestUtilities/TestUtilities.csproj: Language not supported
- src/libraries/Microsoft.Bcl.AsyncInterfaces/tests/Microsoft.Bcl.AsyncInterfaces.Tests.csproj: Language not supported
- src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj: Language not supported
- src/libraries/Microsoft.Bcl.Memory/tests/Microsoft.Bcl.Memory.Tests.csproj: Language not supported
- src/libraries/Microsoft.Bcl.Numerics/tests/Microsoft.Bcl.Numerics.Tests.csproj: Language not supported
- src/libraries/Microsoft.Bcl.TimeProvider/tests/Microsoft.Bcl.TimeProvider.Tests.csproj: Language not supported
- src/libraries/Microsoft.Extensions.Caching.Memory/tests/Microsoft.Extensions.Caching.Memory.Tests.csproj: Language not supported
- src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/Microsoft.Extensions.Configuration.Binder.SourceGeneration.Tests.csproj: Language not supported
- src/libraries/Microsoft.Extensions.Configuration.Binder/tests/UnitTests/Microsoft.Extensions.Configuration.Binder.Tests.csproj: Language not supported
- src/libraries/Microsoft.Extensions.Configuration.CommandLine/tests/Microsoft.Extensions.Configuration.CommandLine.Tests.csproj: Language not supported
- src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/tests/Microsoft.Extensions.Configuration.EnvironmentVariables.Tests.csproj: Language not supported
Comments suppressed due to low confidence (1)
eng/pipelines/libraries/helix-queues-setup.yml:140
- The framework equality check was changed to compare against '1' instead of the expected 'net481'. Please update this condition to use 'net481' to ensure consistency with the intended target framework.
- - ${{ if eq(parameters.jobParameters.framework, 'net48') }}:
3 tasks
akoeplinger
approved these changes
Mar 20, 2025
Member
Author
|
/ba-g failure is unrelated: #103449 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... of previous .NET Framework versions in docs / tests.
NetFrameworkMinimum (net462) -> NetFrameworkCurrent (net481) so that we can start consuming xunit v3 which requires at least net472. Use NetFrameworkCurrent as the actual runtime that is then used is .NET Framework 4.8.1 anyway (innerloop & CI).