[browser] managed Diagnostics.Metrics and Diagnostics.Tracing single-threaded

[pavelsavara]

This change enables Diagnostics.Metrics and Diagnostics.Tracing in single-threaded browser.

The behavior is slightly different from desktop/server dotnet because the events are only propagated on the same thread as application logic. That's when the user code yields to the browser event loop. In well behaved applications, this is often, because that's how you allow the browser to re-render the page. If the user code is running long synchronous loop, the events would be only delivered later.

Implementation

• excuded CounterGroup and RuntimeEventSource from browser build
• split EventPipeEventDispatcher.Threads.cs and EventPipeEventDispatcher.Wasm.cs - make it Task based
• updated AggregationManager - make it timer based for WASM

Other

• fix nullable argument in BeginInstrumentReporting, EndInstrumentReporting and InstrumentPublished

Tests

• enable EventSourceSupport, MetricsSupport MSBuild props for unit tests which need it
• enabled WasmPerfTracing for ActivityTracking test to work, because EventPipeEventProvider.EventActivityIdControl is in libmono-component-diagnostics_tracing which need to be linked in
• enable TestSubscriptionManagerDisposal
• enable RuntimeMetricsTests, ActivityTracking
• MetricEventSourceTests are OuterLoop, but I made them work locally by rewriting them to async.

Fixes #93754
Contributes to #76316

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[pavelsavara]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pavelsavara]

@noahfalk I believe I processed all your feedback. Please have another look.

@tarekgh I executed coreCLR outerloop pipeline and there are quite few timeouts I'm not familiar with.
It seems to me most of them are completely unrelated, because I think I made no change to CoreCLR.

Some of them are about System.Diagnostics.DiagnosticSource.Tests,
passing and timeout
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113524-merge-4ce231f817134eeeb1/System.Diagnostics.DiagnosticSource.Tests/1/console.97f0f45e.log?helixlogtype=result
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113524-merge-d64bee06b6904cb984/System.Diagnostics.DiagnosticSource.Tests/1/console.b25b5eaf.log?helixlogtype=result

timeout during test
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113524-merge-8849796b28c94bb8af/System.Diagnostics.DiagnosticSource.Tests/1/console.e5a2c1aa.log?helixlogtype=result
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113524-merge-1db6ed0772b4439aae/System.Diagnostics.DiagnosticSource.Tests/1/console.6866e220.log?helixlogtype=result

If you guys believe that my changes in MetricEventSourceTests.cs to make it async are causing that I could revert the changes in that file and exclude the test on browser. It's outerloop anyway.

please advise, thanks

[tarekgh]

It seems to me most of them are completely unrelated, because I think I made no change to CoreCLR.

I am seeing this timeout https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113524-merge-1db6ed0772b4439aae/System.Diagnostics.DiagnosticSource.Tests/1/console.6866e220.log?helixlogtype=result, looks these failing in slow platforms (like Debug and Linux Musl). These outer loop tests take a long time so on slow platforms can timeout I guess. I don't recall seeing such failures, but I can see why it can time out. I have re-run the failing tests hopefully it passes. If it is still failing, you may ignore them for now as it is time out and passing in other platforms.

[noahfalk]

👍

[pavelsavara]

/ba-g CI issues are known