Skip to content

Skip inbuild projects in stage2 (built by stage1) #113243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 7, 2025

Stage1 builds it for host, stage2 tries to overwrite the publish dir without libclrjit etc.

Contributes to #106223

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 7, 2025
@am11 am11 added area-NativeAOT-coreclr arch-riscv Related to the RISC-V architecture and removed area-crossgen2-coreclr labels Mar 7, 2025
@am11 am11 requested a review from jkoritzinsky March 7, 2025 02:40
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@am11 am11 mentioned this pull request Mar 7, 2025
@am11 am11 changed the title Use LKG for inbuild projects Skip inbuild projects in stage2 (built by stage1) Mar 7, 2025
@am11
Copy link
Member Author

am11 commented Mar 10, 2025

@jkoritzinsky if it is not conflicting with your planned SB work, could we get it in? It cuts down the build+runtest time from 56m to 35m which will help Samsung CI to incorporate NAOT testing in their infra smoothly, it's a harmless condition for other platforms.

@jkoritzinsky jkoritzinsky merged commit a91d820 into dotnet:main Mar 10, 2025
145 of 148 checks passed
@am11 am11 deleted the patch-30 branch March 10, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants