Skip to content

[10.0/preview-2] JIT: disable array stack allocation #113181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

[10.0/preview-2] JIT: disable array stack allocation #113181

merged 2 commits into from
Mar 6, 2025

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Mar 5, 2025

Preview 2 is missing an important fix for stack-allocated arrays of GC types: #112711. This can lead to unexpected crashes in jitted code.

Disable array stack allocation to work around this.

@AndyAyersMS
[10.0/preview-2] JIT: disable array stack allocation
f1ac70d 
Preview 2 is missing an important fix for stack-allocated arrays of GC types: dotnet#112711.
This can lead to unexpected crashes in jitted code.

Disable array stack allocation to work around this.
Copilot AI review requested due to automatic review settings March 5, 2025 23:32
Copilot AI reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 5, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 5, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Mar 5, 2025

@jeffschwMSFT @JulieLeeMSFT FYI
@dotnet/jit-contrib PTAL

This disables for all arrays. We could try and just disable stack allocation for gc typed arrays.

JulieLeeMSFT
JulieLeeMSFT approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@JulieLeeMSFT JulieLeeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jeffschwMSFT
jeffschwMSFT approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Mar 6, 2025

Failures are mostly in the test case that is testing for this feature... I will have to modify the test case as well since is expecting some arrays to be stack allocated.

But there is one unrelated looking failure on x64

  Starting:    System.Numerics.Tensors.Tests (parallel test collections = on [4 threads], stop on fail = off)
    System.Numerics.Tensors.Tests.ConvertTests.ConvertChecked [FAIL]
      System.OverflowException : Arithmetic operation resulted in an overflow.
      Stack Trace:
        /_/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.ConvertChecked.cs(37,0): at System.Numerics.Tensors.TensorPrimitives.ConvertCheckedFallbackOperator`2.Invoke(TFrom x)

@build-analysis build-analysis bot mentioned this pull request Mar 6, 2025
Closed
3 tasks
@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Mar 6, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 6, 2025

Tell mode as necessary to ship.

@ViktorHofer ViktorHofer merged commit 07b0519 into dotnet:release/10.0-preview2 Mar 6, 2025
102 checks passed
@mangod9 mangod9 mentioned this pull request Mar 6, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@JulieLeeMSFT JulieLeeMSFT JulieLeeMSFT approved these changes

+1 more reviewer

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMS AndyAyersMS

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AndyAyersMS @ViktorHofer @jeffschwMSFT @amanasifkhalid @JulieLeeMSFT