Skip to content

Allow loading side-by-side dependent DLLs in the PGO-instrumented build #112977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Allow loading side-by-side dependent DLLs in the PGO-instrumented build #112977

merged 1 commit into from
Feb 27, 2025

Conversation

jkoritzinsky
Copy link
Member

This is needed to enable loading pgort140.dll from coreclr.dll in our PGO-instrumented runtime build.

cc: @caaavik-msft

@jkoritzinsky
Allow loading side-by-side dependent DLLs in the PGO-instrumented build
5ea1f67 
This is needed to enable loading pgort140.dll from coreclr.dll in our PGO-instrumented runtime build.
@Copilot Copilot AI review requested due to automatic review settings February 27, 2025 05:39
Copilot
Copilot AI reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
Copy link
Member

jkotas commented Feb 27, 2025

Regression introduced by #112359 (cc @AustinWise)

This was referenced Feb 27, 2025
Open
Open
Open
@jkotas jkotas merged commit 42c3190 into main Feb 27, 2025
146 of 148 checks passed
@caaavik-msft caaavik-msft mentioned this pull request Feb 27, 2025
Closed
@jkotas jkotas deleted the jkoritzinsky-patch-1 branch March 16, 2025 05:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@jkotas jkotas jkotas approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure-coreclr
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @jkotas