Skip to content

Cleanup some unused code and signature #112905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 26, 2025
Merged

Conversation

huoyaoyuan
Copy link
Member

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@@ -1580,7 +1579,6 @@ typedef PTR_AssemblyNameBaseObject ASSEMBLYNAMEREF;
#define ArgSlotToBool(s) ((BOOL)(s))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and StringToArgSlot (on lines 1541 and 1571) are also unused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep these in pair for completeness.

@huoyaoyuan
Copy link
Member Author

@jkotas Can you please help to review this?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Apr 26, 2025

/ba-g DeadLetter

@jkotas jkotas merged commit cb4581a into dotnet:main Apr 26, 2025
93 of 95 checks passed
@huoyaoyuan huoyaoyuan deleted the unused-corelib branch April 27, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants