JIT: Move passed-by-reference argument information to new ABI info #112449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @dotnet/jit-contrib @dotnet/samsung @shushanhf |
sirntar
approved these changes
Feb 12, 2025
Comment on lines
+1674
to
+1676
| #if FEATURE_IMPLICIT_BYREFS | ||
| dsc->lvIsImplicitByRef = lvaParameterPassingInfo[i].IsPassedByReference(); | ||
| #endif // FEATURE_IMPLICIT_BYREFS |
There was a problem hiding this comment.
I have found in the past Marking V%02i as a byref parameter from below to be a useful crumb to have a quick understanding of which parameters are by-ref. Preserve it by moving here?
There was a problem hiding this comment.
It currently gets printed by ABIPassingInformation::Dump, so at the top of the JIT dump you will see:
static void Foo(long a, object b, Guid c, List<string>.Enumerator d)
{
}Parameter V00 ABI info: [00..08) reg x0
Parameter V01 ABI info: [00..08) reg x1
Parameter V02 ABI info: 2 segments
[0] [00..08) reg x2
[1] [08..16) reg x3
Parameter V03 ABI info: [00..08) reg x4 (implicit by-ref)Let me know what you think.
amanasifkhalid
approved these changes
Feb 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.