Skip to content

[LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. #112229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

[LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. #112229

merged 1 commit into from
Feb 12, 2025

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented Feb 6, 2025 •
edited
Loading

  • Fix some assertion failures for Debug ILC building Debug NativeAOT testcases.
  • Fix the break of backtrace when already establish the frame pointer chain.
  • Delete some unused codes.

@LuckyXu-HF
[LoongArch64] Fix some assertion failures for Debug ILC building Debu…
ba92680 
…g NativeAOT testcases.

* Fix the break of backtrace when already establish the frame pointer chain.
* Delete some unused codes.
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 6, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2025
@build-analysis build-analysis bot mentioned this pull request Feb 6, 2025
Open
2 tasks
@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Feb 6, 2025 •
edited
Loading

Hi @shushanhf @MichalStrehovsky , could you please review this PR? Thank you.

shushanhf
shushanhf approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 6, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@LuckyXu-HF
Copy link
Contributor Author

Hi @jakobbotsch , could you please help to review this PR? Thanks.

@LuckyXu-HF
Copy link
Contributor Author

Hi @jakobbotsch , could you please review this PR if you have time? Thanks.

@jakobbotsch jakobbotsch merged commit 938f546 into dotnet:main Feb 12, 2025
117 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch February 12, 2025 08:43
grendello added a commit to grendello/runtime that referenced this pull request Feb 12, 2025
@grendello
Merge branch 'main' into dev/grendel/android-clr-host-local
21f8a18 
* main:
  [Android] Run CoreCLR functional tests on Android (dotnet#112283)
  [LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. (dotnet#112229)
  Fix suspicious code fragments (dotnet#112384)
  `__ComObject` doesn't support dynamic interface map (dotnet#112375)
  Native DLLs: only load imported DLLs from System32 (dotnet#112359)
  [main] Update dependencies from dotnet/roslyn (dotnet#112314)
  Update SVE instructions that writes to GC regs (dotnet#112389)
  Bring up android+coreclr windows build.  (dotnet#112256)
  Never use heap for return buffers (dotnet#112060)
  Wait to complete the test before releasing the agile reference. (dotnet#112387)
  Prevent returning disposed HTTP/1.1 connections to the pool (dotnet#112383)
  Fingerprint dotnet.js if writing import map to html is enabled (dotnet#112407)
  Remove duplicate definition of CORECLR_HOSTING_API_LINKAGE (dotnet#112096)
  Update the exception message to reflect current behavior. (dotnet#112355)
  Use enum for frametype not v table (dotnet#112166)
  Enable AltJits build for LoongArch64 and RiscV64 (dotnet#110282)
  Guard members of MonoType union & fix related bugs (dotnet#111645)
  Add optional hooks for debugging OpenSSL memory allocations (dotnet#111539)
  JIT: Optimize struct parameter register accesses in the backend (dotnet#110819)
  NativeAOT: Cover more opcodes in type preinitializer (dotnet#112073)
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@shushanhf shushanhf shushanhf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LuckyXu-HF @jakobbotsch @shushanhf @jkotas