Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual] Merge branch 'release/9.0' => 'release/9.0-staging' #111565

Merged
merged 74 commits into from
Jan 18, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
0d4e67b
Use explicit full-path for loading MsQuic.dll
rzikm Aug 28, 2024
fae6c3e
Fix comment wording
rzikm Aug 28, 2024
703a5be
Merged PR 42181: Use explicit full-path for loading MsQuic.dll
rzikm Oct 7, 2024
f0d72e3
Merge commit '09393c29fa9730ef36a220ba81c0414f3b152e5c'
Oct 7, 2024
7e717e3
Merge commit 'ccff2d8b13f6d3da7c83e158bffb3d689f1b170e'
Oct 7, 2024
d268545
Merge commit '25d5a1fc973c5aa272570c613e6136b2b22e7c00'
Oct 7, 2024
4eddcac
Merge commit 'dfff9ad29ac9ac8f487a51aad2c814ab158676b9'
Oct 8, 2024
507d1a8
Merge commit '5a1eedb3026ee115b654c41ad6422c503e4b0dda'
Oct 8, 2024
8273648
Merge commit '5c0d2265f06b665eba09879ce5990b876602860f'
Oct 9, 2024
02ae0c5
Merge commit '24cfc7cc9dabdbe8607a3bf81ffbedf7e2cbb97f'
Oct 9, 2024
d16f41a
[release/9.0] Simplify array handling to fix issues with jagged and a…
Oct 9, 2024
0017b18
Merge commit 'efbd310dfe4071eb159a42e9952a694fa92d6b17'
Oct 9, 2024
2d871e6
Merge commit '9e16fe2d3d1b88cea5b529c4645a9fb3239890a2'
Oct 10, 2024
1302a7e
Merge commit '226c0347b92c4f9649bcc7ad580f74cb0409580e'
Oct 10, 2024
625d418
Merge commit '24e3ac980094f86022d0a3cc80813f743f67c978'
Oct 10, 2024
c8e2baf
Merge commit '05adda580b5d792fee9c8724236b9719141d213a'
Oct 10, 2024
e4c2c7f
Merge commit 'dd3bd1d48ddee767a0f098f3bed81afb81fca026'
Oct 10, 2024
1ebdea8
Merge commit '870e4660ed1d42f015ff76d6dc7ca92bd7977ce2'
Oct 11, 2024
b9d8a2f
Merge commit '0eb4083345461014ca55682111c273948fe2ec25'
Oct 11, 2024
0ff78bb
Merge commit '4b3ab70d6a7bce7f1980fcc0c6ad2f60c3f5bcb2'
Oct 11, 2024
ce2fe14
Merge commit '6aafadbead76ce05cef125a9a79253bd0cd6b236'
Oct 11, 2024
5127a1f
Merge commit 'b030c4dfdfa1bf287f10f96006619a06bc2000ae'
Oct 11, 2024
f7cb588
Merge commit 'c2da91e256ebcb69f71040eb93b186b0985a2384'
Oct 14, 2024
15324df
Merge commit 'def10840ad64ab4977f0f1dab8eb8de2c75c0589'
Oct 14, 2024
209242a
Merge commit 'a0038e206b689443caf3609836ffbf6ce3568c80'
Oct 14, 2024
695e2b5
Merge commit 'b182a0bdb845cee080bc34e0bc70be154a836431'
Oct 15, 2024
5b7ebdc
Merge commit 'dc9d87fd744deb37df9aa49c1886aba72a67a6c6'
Oct 15, 2024
fcf5dc7
Merge commit 'cf1c582931dc647b8e6ca58c34fcfb20d5d07a42'
Oct 15, 2024
0bdcebf
Merge commit 'b8f5d2538d402d4714b4567af4b05b98aac94d2d'
Oct 15, 2024
d7cbea0
Merge commit '9305d7f71d73c1d1edeb2a06478c998e40deda8d'
Oct 16, 2024
48bcd24
Merge commit '5d276d9e9b096229176fc9c760e9b29e7ad0733c'
Oct 16, 2024
64edceb
Merge commit 'd3981726bc8b0e179db50301daf9f22d42393096'
Oct 16, 2024
0621080
Merge commit 'd1944e672a6f819ddd2ad90533c9f35a30258aa9'
Oct 17, 2024
644ee36
Merge commit '937db9fe04f9e952619950ae86acdfaebfc80c77'
Oct 17, 2024
77833cf
Merge commit '5663a27d225fc982455a99f18e837338889baa88'
Oct 17, 2024
59cbc74
Suppress IL3000 in MsQuicApi constructor
elinor-fung Oct 17, 2024
a84babf
Merge commit 'e3130360deb1341e96af622ff1128439f649005e'
Oct 17, 2024
abd2c00
Merge commit '316d718c78317e249c651f925d8a4b68638d9af1'
Oct 17, 2024
26f3296
Merge commit 'b678c8a49022eb25e8c9de5ed3496d4a26b56e31'
Oct 18, 2024
e8d2552
Merge commit '83d152c4b5ff2f50a6d01a20fcc22be07da05ab3'
Oct 18, 2024
87ac28b
Merge commit 'ecefb5e0412bd05841012efe3d7fd914c400343a'
Oct 18, 2024
9c52987
Merge commit '197db4ff0ded5f02e2d050f1310f297265d19e3d'
Oct 18, 2024
ab1c0fb
Merge commit 'd5baa14e684167fabdd980ee16d307994398f912'
Oct 22, 2024
2df1137
Merge commit 'f9b6a512f7dea63d0c55648576b11790362c7e12'
Oct 22, 2024
0456c7e
Merge commit '2b46f3a7eb3d0df99c523e5648f00cc8b53caa05'
Oct 23, 2024
5f6da41
Merge commit '7b9e6158be5956687564d249afdad36fbc57750e'
Oct 28, 2024
7dab903
Update dependencies from https://github.com/dotnet/emsdk build 202410…
dotnet-maestro[bot] Oct 29, 2024
9d5a6a9
Merge commit '7dab903b20269d78c6bc08d5269947db7d35c22b'
Oct 29, 2024
940e395
Update branding to 9.0.1 (#109563)
vseanreesermsft Nov 7, 2024
29dbf1a
Merge commit '940e395337ef32782723b789e530aa4abd72b054'
Nov 7, 2024
e7a0653
Merge commit '9d5a6a9aa463d6d10b0b0ba6d5982cc82f363dc3' into internal…
vseanreesermsft Nov 12, 2024
f6615d2
Merging internal commits for release/9.0 (#109744)
carlossanlop Nov 26, 2024
74e5e40
Merge commit 'f6615d27fdbef2e7216d9762aaea9a6aa49e1be5'
Nov 26, 2024
32d8ea6
Merged PR 45621: Update DIA to 17.12.0-beta1.24603.5
Dec 3, 2024
9da8c6a
[release/9.0] Fix length check for Convert.TryToHexString{Lower} (#11…
github-actions[bot] Dec 3, 2024
6221f4e
Merge commit '9da8c6a4a6ea03054e776275d3fd5c752897842e'
Dec 3, 2024
cc58c28
[release/9.0] Update dependencies from dotnet/emsdk (#109523)
dotnet-maestro[bot] Dec 3, 2024
8437635
Merge commit 'cc58c2832c5c5bcbf90d118a8b3c504b2a87c820'
Dec 3, 2024
38709f8
Merge branch 'release/9.0' into release/9.0-staging
carlossanlop Dec 3, 2024
462630b
Merge pull request #110370 from carlossanlop/release/9.0-staging
carlossanlop Dec 3, 2024
69ae1ac
Merge commit '462630b3c311cade6426c53e9b3ee3b89bf217a2'
Dec 3, 2024
757d97b
Switch to automatic 8.0 version updates (#110586)
marcpopMSFT Dec 10, 2024
6c7cf91
Merge commit '757d97b1a5f00cab30fc37f68aba9eec6e8b4e00'
Dec 10, 2024
756e620
Update dependencies from https://github.com/dotnet/emsdk build 202412…
dotnet-maestro[bot] Dec 10, 2024
c8acea2
Merge commit '756e62050722c168cd3b753be73b7cbcd93f06d6'
Dec 10, 2024
3c456bc
Update branding to 9.0.2 (#111172)
vseanreesermsft Jan 10, 2025
d8b1554
Merge branch 'release/9.0' into release/9.0-staging
carlossanlop Jan 14, 2025
55b2924
[release/9.0] Fix Encoding regression (#111367)
github-actions[bot] Jan 14, 2025
63b7284
Merge pull request #111378 from carlossanlop/release/9.0-staging
carlossanlop Jan 14, 2025
f8e3b98
Merge commit 'c8acea22626efab11c13778c028975acdc34678f' into internal…
vseanreesermsft Jan 14, 2025
cbcec76
Merge pull request #111422 from carlossanlop/release/9.0-staging
carlossanlop Jan 14, 2025
63cb882
Since we bumped the NDK in https://github.com/dotnet/dotnet-buildtool…
steveisok Jan 14, 2025
6a86517
[release/9.0] Support generic fields in PersistedAssemblyBuilder (#11…
github-actions[bot] Jan 15, 2025
692a3b6
Merged PR 45621: Update DIA to 17.12.0-beta1.24603.5 (#111428)
carlossanlop Jan 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[release/9.0] Fix Encoding regression (#111367)
* Fix Encoding regression

* Feedback addressing

* Fix the test

---------

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
  • Loading branch information
github-actions[bot] and tarekgh authored Jan 14, 2025
commit 55b29248c4608a132baab4d5abe176b5768bfc16
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,14 @@ internal unsafe bool AddChar(char ch)
return AddChar(ch, 1);
}


internal unsafe bool AddChar(char ch1, char ch2, int numBytes)
{
if (_chars is null)
{
_charCountResult += 2;
return true;
}

// Need room for 2 chars
if (_charEnd - _chars < 2)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ public static void TestDefaultEncodings()
Assert.Contains(mappedEncoding, CrossplatformDefaultEncodings().Union(CodePageInfo().Select(i => Map((int)i[0], (string)i[1]))));

TestRegister1252();
TestMultiBytesEncodingsSupportSurrogate();
}

private static void ValidateDefaultEncodings()
Expand Down Expand Up @@ -639,6 +640,23 @@ public static void TestEncodingDisplayNames(int codePage, string webName, string
Assert.All(name, c => Assert.True(c >= ' ' && c < '~' + 1, "Name: " + name + " contains character: " + c));
}

private static void TestMultiBytesEncodingsSupportSurrogate()
{
Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);

Encoding encoding = Encoding.GetEncoding("GB18030");
Assert.NotNull(encoding);

string surrogatePair = "\uD840\uDE13"; // Surrogate Pair codepoint '𠈓' \U00020213
byte[] expectedBytes = new byte[] { 0x95, 0x32, 0xB7, 0x37 };

Assert.Equal(expectedBytes, encoding.GetBytes(surrogatePair));
Assert.Equal(expectedBytes.Length, encoding.GetByteCount(surrogatePair));

Assert.Equal(surrogatePair, encoding.GetString(expectedBytes));
Assert.Equal(surrogatePair.Length, encoding.GetCharCount(expectedBytes));
}

// This test is run as part of the default mappings test, since it modifies global state which that test
// depends on.
private static void TestRegister1252()
Expand Down
Loading