ConfigurationBuilder.AddJsonFile can't fire OnChange event using relative paths #111101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
davidfowl
reviewed
Jan 12, 2025
| @@ -165,12 +165,17 @@ private IChangeToken GetOrAddChangeToken(string pattern) | |||
| } | |||
| else | |||
| { | |||
| changeToken = GetOrAddFilePathChangeToken(pattern); | |||
| // get rid of \. in Windows and ./ in UNIX's at the start of path file | |||
| var filePath = RemoveRelativePathSegment(pattern); | |||
There was a problem hiding this comment.
I don't think it breaks anything, it looks like a bug fix to me. Unless, there's someone relying on the fact that on change does not get fired for his files when specifying them with starting ./ which is highly improbable because he could just pass false to AddJsonFile if didn't want to subscribe to them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71386