Avoid all compiler optimization on embedded apphost hash #110554

omajid · 2024-12-09T22:58:13Z

We assume that there is a single copy of the apphost hash in the apphost binary. And that it hasn't been modified by the compiler. However, the compiler can optimize the hash multiple ways, including re-ordering elements of the hash or duplicating the contents of the hash. This can currently happen under certain compiler versions and optimization flags.

Try and avoid that by marking the hash as a volatile string and implementing comparisons/copying/initialization that respects that.

Fixes: #109611

We assume that there is a single copy of the apphost hash in the apphost binary. And that it hasn't been modified by the compiler. However, the compiler can optimize the hash multiple ways, including re-ordering elements of the hash or duplicating the contents of the hash. This can currently happen under certain compiler versions and optimization flags. Try and avoid that by marking the hash as a volatile string and implementing comparisons/copying/initialization that respects that. Fixes: dotnet#109611

omajid · 2024-12-12T15:15:15Z

src/native/corehost/corehost.cpp


    static const char hi_part[] = EMBED_HASH_HI_PART_UTF8;
    static const char lo_part[] = EMBED_HASH_LO_PART_UTF8;

-    if (!pal::clr_palstring(embed, app_dll))


Implementing pal::clr_palstring per-platform to handle volatile correctly looked much more involved that creating a non-volatile copy instead.

Strangely enough, even the non-volatile copy still needed the no-opt memory compare to stop creating duplicate instances of the embedded hash. I wonder if the compiler ignored volatile data when it started optimizing the non-volatile copy?

My guess is that the compiler can see all operations on the value and that the value does not escape, and thus volatile can be safely ignored.

It may help to move the value to the global scope and mark it as extern or extern "C". It should prevent the compiler from making assumptions the value.

@omajid Have you tried applying extern?

I suspect it won't help after thinking about it some more. The main problem that this PR is trying to solve is suppressing undesirable optimizations in whole program optimization mode. The compiler can see all uses of the symbol in this mode. extern won't prevent it from making this observation. We would have to artificially export the symbol from the binary to prevent the optimizations, but that is undesirable for other reasons.

tmds · 2024-12-12T17:36:22Z

src/native/corehost/corehost.cpp

@@ -48,18 +66,21 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll)
    // Contains the EMBED_HASH_FULL_UTF8 value at compile time or the managed DLL name replaced by "dotnet build".
    // Must not be 'const' because std::string(&embed[0]) below would bind to a const string ctor plus length
    // where length is determined at compile time (=64) instead of the actual length of the string at runtime.
-    static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8;     // series of NULs followed by embed hash string
+    volatile static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8;     // series of NULs followed by embed hash string


I'm curious what happens if you change:

static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string

to:

static const char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; char embed[EMBED_MAX]; to_non_volatile(const_embed, embed, EMBED_MAX);

And keep the remainder of the file as it were (except for adding to_non_volatile).

The comment above says we can't use const.

I made this change as the full diff:

diff --git a/src/native/corehost/corehost.cpp b/src/native/corehost/corehost.cpp index 6de7acfbd08..d0c90f4bfcf 100644 --- a/src/native/corehost/corehost.cpp +++ b/src/native/corehost/corehost.cpp @@ -40,6 +40,24 @@ #define EMBED_HASH_LO_PART_UTF8 "74e592c2fa383d4a3960714caef0c4f2" #define EMBED_HASH_FULL_UTF8 (EMBED_HASH_HI_PART_UTF8 EMBED_HASH_LO_PART_UTF8) // NUL terminated +void to_non_volatile(volatile const char* cstr, char* output, size_t length) +{ + for (size_t i = 0; i < length; i++) + { + output[i] = cstr[i]; + } +} + +bool compare_memory_nooptimization(volatile const char* a, volatile const char* b, size_t length) +{ + for (size_t i = 0; i < length; i++) + { + if (*a++ != *b++) + return false; + } + return true; +} + bool is_exe_enabled_for_execution(pal::string_t* app_dll) { constexpr int EMBED_SZ = sizeof(EMBED_HASH_FULL_UTF8) / sizeof(EMBED_HASH_FULL_UTF8[0]); @@ -48,11 +66,14 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll) // Contains the EMBED_HASH_FULL_UTF8 value at compile time or the managed DLL name replaced by "dotnet build". // Must not be 'const' because std::string(&embed[0]) below would bind to a const string ctor plus length // where length is determined at compile time (=64) instead of the actual length of the string at runtime. - static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string + volatile static char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string static const char hi_part[] = EMBED_HASH_HI_PART_UTF8; static const char lo_part[] = EMBED_HASH_LO_PART_UTF8; + char embed[EMBED_MAX]; + to_non_volatile(const_embed, embed, EMBED_MAX); + if (!pal::clr_palstring(embed, app_dll)) { trace::error(_X("The managed DLL bound to this executable could not be retrieved from the executable image."));

The compiler embeds the string twice:

++ grep --byte-offset --only-matching --text c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca ./artifacts/obj/coreclr/linux.x64.Release/Corehost.Static/CMakeFiles/singlefilehost.dir/home/omajid/runtime/src/native/corehost/corehost.cpp.o 320:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca 4816:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca

Using const static char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; produces the exact same result.

The comment above says we can't use const.

Like this, it is also working around a compiler optimization. I thought we may tackle both together.

Using const static char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; produces the exact same result.

That is: you also tried without the volatile?

I'm surprised it found the need to duplicate const data which shouldn't be optimized for a specific usage.

Thanks for giving it try!

You mean like this?

diff --git a/src/native/corehost/corehost.cpp b/src/native/corehost/corehost.cpp index 6de7acfbd08..f77fbe63347 100644 --- a/src/native/corehost/corehost.cpp +++ b/src/native/corehost/corehost.cpp @@ -40,6 +40,14 @@ #define EMBED_HASH_LO_PART_UTF8 "74e592c2fa383d4a3960714caef0c4f2" #define EMBED_HASH_FULL_UTF8 (EMBED_HASH_HI_PART_UTF8 EMBED_HASH_LO_PART_UTF8) // NUL terminated +void to_non_volatile(volatile const char* cstr, char* output, size_t length) +{ + for (size_t i = 0; i < length; i++) + { + output[i] = cstr[i]; + } +} + bool is_exe_enabled_for_execution(pal::string_t* app_dll) { constexpr int EMBED_SZ = sizeof(EMBED_HASH_FULL_UTF8) / sizeof(EMBED_HASH_FULL_UTF8[0]); @@ -48,11 +56,14 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll) // Contains the EMBED_HASH_FULL_UTF8 value at compile time or the managed DLL name replaced by "dotnet build". // Must not be 'const' because std::string(&embed[0]) below would bind to a const string ctor plus length // where length is determined at compile time (=64) instead of the actual length of the string at runtime. - static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string + volatile static const char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string static const char hi_part[] = EMBED_HASH_HI_PART_UTF8; static const char lo_part[] = EMBED_HASH_LO_PART_UTF8; + char embed[EMBED_MAX]; + to_non_volatile(const_embed, embed, EMBED_MAX); + if (!pal::clr_palstring(embed, app_dll)) { trace::error(_X("The managed DLL bound to this executable could not be retrieved from the executable image."));

This leads to:

$ grep --byte-offset --only-matching --text c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca ./artifacts/obj/coreclr/linux.x64.Release/Corehost.Static/CMakeFiles/singlefilehost.dir/home/omajid/runtime/src/native/corehost/corehost.cpp.o 256:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca 4752:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca

const vs non-const doesn't make a difference, as far as I can see:

diff --git a/src/native/corehost/corehost.cpp b/src/native/corehost/corehost.cpp index 6de7acfbd08..7c6c1244815 100644 --- a/src/native/corehost/corehost.cpp +++ b/src/native/corehost/corehost.cpp @@ -40,6 +40,14 @@ #define EMBED_HASH_LO_PART_UTF8 "74e592c2fa383d4a3960714caef0c4f2" #define EMBED_HASH_FULL_UTF8 (EMBED_HASH_HI_PART_UTF8 EMBED_HASH_LO_PART_UTF8) // NUL terminated +void to_non_volatile(volatile const char* cstr, char* output, size_t length) +{ + for (size_t i = 0; i < length; i++) + { + output[i] = cstr[i]; + } +} + bool is_exe_enabled_for_execution(pal::string_t* app_dll) { constexpr int EMBED_SZ = sizeof(EMBED_HASH_FULL_UTF8) / sizeof(EMBED_HASH_FULL_UTF8[0]); @@ -48,11 +56,14 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll) // Contains the EMBED_HASH_FULL_UTF8 value at compile time or the managed DLL name replaced by "dotnet build". // Must not be 'const' because std::string(&embed[0]) below would bind to a const string ctor plus length // where length is determined at compile time (=64) instead of the actual length of the string at runtime. - static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string + volatile static char const_embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string static const char hi_part[] = EMBED_HASH_HI_PART_UTF8; static const char lo_part[] = EMBED_HASH_LO_PART_UTF8; + char embed[EMBED_MAX]; + to_non_volatile(const_embed, embed, EMBED_MAX); + if (!pal::clr_palstring(embed, app_dll)) { trace::error(_X("The managed DLL bound to this executable could not be retrieved from the executable image."));

$ grep --byte-offset --only-matching --text c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca ./artifacts/obj/coreclr/linux.x64.Release/Corehost.Static/CMakeFiles/singlefilehost.dir/home/omajid/runtime/src/native/corehost/corehost.cpp.o 256:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca 4752:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca

My conclusion is that I neither understand why all of these don't work, and why what is in the PR does work. 😅

I didn't realize the duplication comes from the compares against the parts and not from the complete embed...

I wonder if introducing overlap in the parts wouldn't eliminate the issue too.

diff --git a/src/native/corehost/corehost.cpp b/src/native/corehost/corehost.cpp index 6de7acfbd08..e3d0ca72891 100644 --- a/src/native/corehost/corehost.cpp +++ b/src/native/corehost/corehost.cpp @@ -36,9 +36,10 @@ * o https://en.wikipedia.org/wiki/Comparison_of_file_systems * has more details on maximum file name sizes. */ -#define EMBED_HASH_HI_PART_UTF8 "c3ab8ff13720e8ad9047dd39466b3c89" // SHA-256 of "foobar" in UTF-8 -#define EMBED_HASH_LO_PART_UTF8 "74e592c2fa383d4a3960714caef0c4f2" -#define EMBED_HASH_FULL_UTF8 (EMBED_HASH_HI_PART_UTF8 EMBED_HASH_LO_PART_UTF8) // NUL terminated +#define EMBED_HASH_PART_1_UTF8 "c3ab8ff13720e8ad9047dd39" // SHA-256 of "foobar" in UTF-8 +#define EMBED_HASH_PART_2_UTF8 "466b3c8974e592c2fa383d4a" +#define EMBED_HASH_PART_3_UTF8 "3960714caef0c4f2" +#define EMBED_HASH_FULL_UTF8 (EMBED_HASH_PART_1_UTF8 EMBED_HASH_PART_2_UTF8 EMBED_HASH_PART_3_UTF8) // NUL terminated bool is_exe_enabled_for_execution(pal::string_t* app_dll) { @@ -50,8 +51,8 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll) // where length is determined at compile time (=64) instead of the actual length of the string at runtime. static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8; // series of NULs followed by embed hash string - static const char hi_part[] = EMBED_HASH_HI_PART_UTF8; - static const char lo_part[] = EMBED_HASH_LO_PART_UTF8; + static const char hi_part[] = (EMBED_HASH_PART_1_UTF8 EMBED_HASH_PART_2_UTF8); + static const char lo_part[] = (EMBED_HASH_PART_2_UTF8 EMBED_HASH_PART_3_UTF8); if (!pal::clr_palstring(embed, app_dll)) { @@ -73,9 +74,9 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll) // So use two parts of the string that will be unaffected by the edit. size_t hi_len = (sizeof(hi_part) / sizeof(hi_part[0])) - 1; size_t lo_len = (sizeof(lo_part) / sizeof(lo_part[0])) - 1; - if (binding.size() >= (hi_len + lo_len) + if (binding.size() >= (EMBED_SZ - 1) && binding.compare(0, hi_len, &hi_part[0]) == 0 - && binding.compare(hi_len, lo_len, &lo_part[0]) == 0) + && binding.compare(EMBED_SZ - 1 - lo_len, lo_len, &lo_part[0]) == 0) { trace::error(_X("This executable is not bound to a managed DLL to execute. The binding value is: '%s'"), app_dll->c_str()); return false;

I assume the above to would work because the two parts that the compiler optimizes against with the overlap are less likely to form the whole embed due to the compiler optimizations than they currently are. The embed is split in two parts to avoid them forming the whole, and this is adding to that approach.

If this works, it also means that the to_non_volatile logic that is in the PR is not needed because the above is only about the comparison against the parts.

The difference between compare_memory_nooptimization and the above is that the former leaves out any possibility of the compiler optimizing the comparison (and therefore potentially reintroducing the issue as compilers get "smarter").

omajid · 2024-12-12T19:59:38Z

Rewriting volatile-based implementations instead of std::string also seems to work:

diff --git a/src/native/corehost/corehost.cpp b/src/native/corehost/corehost.cpp
index 6de7acfbd08..d5e5fc3fb61 100644
--- a/src/native/corehost/corehost.cpp
+++ b/src/native/corehost/corehost.cpp
@@ -40,6 +40,33 @@
 #define EMBED_HASH_LO_PART_UTF8 "74e592c2fa383d4a3960714caef0c4f2"
 #define EMBED_HASH_FULL_UTF8    (EMBED_HASH_HI_PART_UTF8 EMBED_HASH_LO_PART_UTF8) // NUL terminated
 
+void to_non_volatile(volatile const char* cstr, char* output, size_t length)
+{
+    for (size_t i = 0; i < length; i++)
+    {
+        output[i] = cstr[i];
+    }
+}
+
+bool compare_memory_nooptimization(volatile const char* a, volatile const char* b, size_t length)
+{
+    for (size_t i = 0; i < length; i++)
+    {
+        if (*a++ != *b++)
+            return false;
+    }
+    return true;
+}
+
+size_t strlen_nooptimization(volatile const char* a)
+{
+    for (size_t i = 0; ; i++)
+    {
+       if (a[i] == 0)
+               return i;
+    }
+}
+
 bool is_exe_enabled_for_execution(pal::string_t* app_dll)
 {
     constexpr int EMBED_SZ = sizeof(EMBED_HASH_FULL_UTF8) / sizeof(EMBED_HASH_FULL_UTF8[0]);
@@ -48,21 +75,24 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll)
     // Contains the EMBED_HASH_FULL_UTF8 value at compile time or the managed DLL name replaced by "dotnet build".
     // Must not be 'const' because std::string(&embed[0]) below would bind to a const string ctor plus length
     // where length is determined at compile time (=64) instead of the actual length of the string at runtime.
-    static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8;     // series of NULs followed by embed hash string
+    volatile static char embed[EMBED_MAX] = EMBED_HASH_FULL_UTF8;     // series of NULs followed by embed hash string
 
     static const char hi_part[] = EMBED_HASH_HI_PART_UTF8;
     static const char lo_part[] = EMBED_HASH_LO_PART_UTF8;
 
-    if (!pal::clr_palstring(embed, app_dll))
+    char embed_non_volatile[EMBED_MAX];
+    to_non_volatile(embed, embed_non_volatile, EMBED_MAX);
+
+    if (!pal::clr_palstring(embed_non_volatile, app_dll))
     {
         trace::error(_X("The managed DLL bound to this executable could not be retrieved from the executable image."));
         return false;
     }
 
-    std::string binding(&embed[0]);
+    size_t length = strlen_nooptimization(embed);
 
     // Check if the path exceeds the max allowed size
-    if (binding.size() > EMBED_MAX - 1) // -1 for null terminator
+    if (length > EMBED_MAX - 1) // -1 for null terminator
     {
         trace::error(_X("The managed DLL bound to this executable is longer than the max allowed length (%d)"), EMBED_MAX - 1);
         return false;
@@ -73,9 +103,9 @@ bool is_exe_enabled_for_execution(pal::string_t* app_dll)
     // So use two parts of the string that will be unaffected by the edit.
     size_t hi_len = (sizeof(hi_part) / sizeof(hi_part[0])) - 1;
     size_t lo_len = (sizeof(lo_part) / sizeof(lo_part[0])) - 1;
-    if (binding.size() >= (hi_len + lo_len)
-        && binding.compare(0, hi_len, &hi_part[0]) == 0
-        && binding.compare(hi_len, lo_len, &lo_part[0]) == 0)
+    if (length >= (hi_len + lo_len)
+        && compare_memory_nooptimization(embed, hi_part, hi_len)
+        && compare_memory_nooptimization(embed + hi_len, lo_part, lo_len))
     {
         trace::error(_X("This executable is not bound to a managed DLL to execute. The binding value is: '%s'"), app_dll->c_str());
         return false;

$ grep --byte-offset --only-matching --text c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca ./artifacts/obj/coreclr/linux.x64.Release/Corehost.Static/CMakeFiles/singlefilehost.dir/home/omajid/runtime/src/native/corehost/corehost.cpp.o
5696:c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714ca

agocke · 2025-01-13T21:34:32Z

@AaronRobinsonMSFT Can you also take a look at this? Would appreciate your C++ knowledge.

AaronRobinsonMSFT · 2025-02-10T21:06:29Z

@omajid or @tmds Is there anything I can help with here? Would it possible to get a TL;DR for the current state of the problem and our current avenue for investigation?

omajid · 2025-02-19T21:06:39Z

@AaronRobinsonMSFT

TLDR of the problem: the apphost embeds a hash string, which is supposed to get ovewrriten with the final application name. On x86_64, with some compiler optimizations (eg, -march=x86-64-v3) the hash gets embedded multiple times (some instances are used by AVX instructions and others by standard x86 instructions). That breaks the SDK logic around replacing the hash with the app path.

TLDR of the solution: We are exploring how to tell the compiler to stop optimizing the hash. I don't fully understand the compiler's behaviour (maybe others here do). We have come up with some solutions that seem to work. We haven't come up with a easy to read and nice-to-maintain solution that everyone is happy with.

Part of the delay is that I was on PTO and busy with .NET releases, so this got put on the back-burner from my side.

tmds · 2025-03-11T13:49:47Z

I reproduced the issue on my machine by compiling with -march=x86-64-v3.

Splitting in 3 parts with overlap (per Avoid all compiler optimization on embedded apphost hash #110554 (comment)) fixes the issue.
or only the compare_memory_nooptimization from this PR is enough (per Avoid all compiler optimization on embedded apphost hash #110554 (comment)).

The difference between these is that in the first case the compiler will still do some optimization on the comparison and for the latter it will do none.

The root cause of the issue is that corehost contains the hash once for substitution and once for comparison. The one for comparison is already split in two so it wouldn't not match for substitution. Due to the optimizations for comparison under -march=x86-64-v3 the two halves form the whole again (causing it to become a substitution match). Changes like the ones above prevent that.

am11 · 2025-03-11T14:30:18Z

In main branch, does dropping static and decorating it with used as: char embed[EMBED_MAX] __attribute__((used)) = EMBED_HASH_FULL_UTF8; help with this issue? If it does, then we can put it under #ifndef TARGET_WINDOWS.

We had similar problem with eng/native/version.c in diagnostics repo a while back when we ported it from runtime to diagnostics https://github.com/dotnet/diagnostics/blob/0a1d791ae48165f06545180d5242714a632ef516/CMakeLists.txt#L46.

runtime and diagnostics repo share the eng/native infra as a whole (one way periodic sync of code runtime->diag)
arcade provides the computed value of version, which is replaced in a static array at build time in version.c.
in diagnostics, we additionally drop the static modified in cmake because that array is actually used by the code
- in runtime repo, requirement is to only stash it somewhere inside the binary so we can use strings binary | grep '@(#)' to find the version is distributed binary

Now the diagnostics binaries always have one single string and runtime binaries may have duplicate, but it's only based on observation.

tmds · 2025-03-11T14:56:28Z

In main branch, does dropping static and decorating it with used as: char embed[EMBED_MAX] attribute((used)) = EMBED_HASH_FULL_UTF8; help with this issue?

I checked, and it doesn't.

The problem originates from the comparison with the two literal parts. This doesn't change that comparison.

tmds · 2025-03-12T09:30:49Z

@AaronRobinsonMSFT @jkotas do you have a preference between these 2 options: #110554 (comment)?

jkotas · 2025-03-12T13:15:35Z

@AaronRobinsonMSFT @jkotas do you have a preference between these 2 options: #110554 (comment)?

As you have said, the first option depends on the compiler optimizations not being smart enough. It can change any time.

The second option - that says very explicitly "do not optimize this" - looks better to me.

tmds · 2025-03-12T13:27:56Z

The second option - that says very explicitly "do not optimize this" - looks better to me.

Sounds good.

@omajid can you please update the PR so it only includes the changes from binding.compare to compare_memory_nooptimization? The other changes should not be needed.

src/native/corehost/corehost.cpp

AaronRobinsonMSFT · 2025-03-27T03:42:00Z

@tmds @omajid I've updated the branch. Can one of you please take a look and confirm this addresses the issue.

tmds · 2025-03-27T08:52:36Z

Can one of you please take a look and confirm this addresses the issue.

Yes, it does.

src/native/corehost/corehost.cpp

AaronRobinsonMSFT · 2025-03-29T17:18:27Z

/ba-g wasm timeouts

* Avoid all compiler optimization on embedded apphost hash We assume that there is a single copy of the apphost hash in the apphost binary. And that it hasn't been modified by the compiler. However, the compiler can optimize the hash multiple ways, including re-ordering elements of the hash or duplicating the contents of the hash. This can currently happen under certain compiler versions and optimization flags. Try and avoid that by marking the hash as a volatile string and implementing comparisons that respects that. --------- Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

ghost added the area-Host label Dec 9, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 9, 2024

omajid force-pushed the volatile-apphost-ash branch from 1ebf110 to 81e3213 Compare December 10, 2024 00:16

omajid force-pushed the volatile-apphost-ash branch 2 times, most recently from 74ea3b1 to aa103bb Compare December 10, 2024 16:57

This was referenced Dec 10, 2024

Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928

Open

Test failures in JSImportGenerator.Unit.Tests.Compiles.ValidateGeneratedSourceOutput #110575

Closed

omajid force-pushed the volatile-apphost-ash branch from aa103bb to 265d78f Compare December 10, 2024 22:11

build-analysis bot mentioned this pull request Dec 11, 2024

System.Formats.Nrbf.Tests timeouts #110285

Closed

omajid force-pushed the volatile-apphost-ash branch from 265d78f to 8d4a245 Compare December 11, 2024 22:02

omajid force-pushed the volatile-apphost-ash branch from 8d4a245 to 4e33337 Compare December 11, 2024 22:29

build-analysis bot mentioned this pull request Dec 12, 2024

[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090

Closed

omajid marked this pull request as ready for review December 12, 2024 15:14

omajid commented Dec 12, 2024

View reviewed changes

tmds reviewed Dec 12, 2024

View reviewed changes

AaronRobinsonMSFT requested a review from elinor-fung December 12, 2024 21:22

AaronRobinsonMSFT reviewed Mar 12, 2025

View reviewed changes

src/native/corehost/corehost.cpp Outdated Show resolved Hide resolved

Apply feedback

2c67deb

This was referenced Mar 27, 2025

[wasm][AOT] emcc : error - received SIGKILL (-9) #89402

Open

System.Net.Quic tests timeout #107761

Open

System.Net.Requests test timeout #113883

Closed

tmds reviewed Mar 27, 2025

View reviewed changes

src/native/corehost/corehost.cpp Outdated Show resolved Hide resolved

tmds reviewed Mar 27, 2025

View reviewed changes

src/native/corehost/corehost.cpp Show resolved Hide resolved

tmds reviewed Mar 27, 2025

View reviewed changes

src/native/corehost/corehost.cpp Outdated Show resolved Hide resolved

Feedback

854143d

This was referenced Mar 28, 2025

/root/helix/work/correlation/scripts/<hash>/execute.sh: Permission denied dotnet/dnceng#3412

Open

System.TimeoutException : The operation has timed out. dotnet/dnceng#5279

Open

tmds reviewed Mar 28, 2025

View reviewed changes

src/native/corehost/corehost.cpp Show resolved Hide resolved

tmds approved these changes Mar 28, 2025

View reviewed changes

Feedback

842d62e

AaronRobinsonMSFT approved these changes Mar 28, 2025

View reviewed changes

build-analysis bot mentioned this pull request Mar 29, 2025

[QUIC & HTTP/3] Handshake Timeout on tests #104426

Open

AaronRobinsonMSFT merged commit 914ce6f into dotnet:main Mar 29, 2025
147 of 151 checks passed

github-actions bot locked and limited conversation to collaborators Apr 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid all compiler optimization on embedded apphost hash #110554

Avoid all compiler optimization on embedded apphost hash #110554

omajid commented Dec 9, 2024

omajid Dec 12, 2024 •

edited

Loading

jkotas Dec 12, 2024 •

edited

Loading

AaronRobinsonMSFT Jan 15, 2025

jkotas Jan 15, 2025 •

edited

Loading

tmds Dec 12, 2024

omajid Dec 12, 2024

omajid Dec 12, 2024

omajid Dec 12, 2024

tmds Dec 12, 2024

omajid Dec 12, 2024

omajid Dec 12, 2024

tmds Dec 12, 2024 •

edited

Loading

tmds Dec 12, 2024

tmds Jan 16, 2025 •

edited

Loading

omajid commented Dec 12, 2024

agocke commented Jan 13, 2025

AaronRobinsonMSFT commented Feb 10, 2025

omajid commented Feb 19, 2025

tmds commented Mar 11, 2025 •

edited

Loading

am11 commented Mar 11, 2025

tmds commented Mar 11, 2025 •

edited

Loading

tmds commented Mar 12, 2025

jkotas commented Mar 12, 2025

tmds commented Mar 12, 2025

AaronRobinsonMSFT commented Mar 27, 2025

tmds commented Mar 27, 2025

AaronRobinsonMSFT commented Mar 29, 2025

Avoid all compiler optimization on embedded apphost hash #110554

Avoid all compiler optimization on embedded apphost hash #110554

Conversation

omajid commented Dec 9, 2024

omajid Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

jkotas Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkotas Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmds Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmds Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

omajid commented Dec 12, 2024

agocke commented Jan 13, 2025

AaronRobinsonMSFT commented Feb 10, 2025

omajid commented Feb 19, 2025

tmds commented Mar 11, 2025 • edited Loading

am11 commented Mar 11, 2025

tmds commented Mar 11, 2025 • edited Loading

tmds commented Mar 12, 2025

jkotas commented Mar 12, 2025

tmds commented Mar 12, 2025

AaronRobinsonMSFT commented Mar 27, 2025

tmds commented Mar 27, 2025

AaronRobinsonMSFT commented Mar 29, 2025

omajid Dec 12, 2024 •

edited

Loading

jkotas Dec 12, 2024 •

edited

Loading

jkotas Jan 15, 2025 •

edited

Loading

tmds Dec 12, 2024 •

edited

Loading

tmds Jan 16, 2025 •

edited

Loading

tmds commented Mar 11, 2025 •

edited

Loading

tmds commented Mar 11, 2025 •

edited

Loading