Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize JTRUE(cast_helper EQ/NE null) expansion #110272

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+36 −3
Open

Optimize JTRUE(cast_helper EQ/NE null) expansion #110272

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
277938d
Optimize JTRUE(cast_helper EQ/NE null) expansion
EgorBo Nov 29, 2024
285a5a0
rename
EgorBo Nov 29, 2024
d4b269d
fix bug
EgorBo Nov 30, 2024
11b8d1a
fix bug
EgorBo Nov 30, 2024
97e2cd4
Merge branch 'main' of github.com:dotnet/runtime into diamond-shape-cast
EgorBo Dec 1, 2024
c925d39
more diffs
EgorBo Dec 1, 2024
746c9be
Update helperexpansion.cpp
EgorBo Dec 1, 2024
854ebe6
Merge branch 'main' into diamond-shape-cast
EgorBo Dec 18, 2024
8bdbc8d
Merge branch 'main' into diamond-shape-cast
EgorBo Jan 13, 2025
81e13d0
Merge branch 'main' into diamond-shape-cast
EgorBo Jan 14, 2025
2e51a2e
Merge branch 'main' of https://github.com/dotnet/runtime into diamond…
EgorBo Feb 9, 2025
8550a25
fix failures
EgorBo Feb 9, 2025
32a34ca
fix regressions
EgorBo Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bug
  • Loading branch information
@EgorBo
EgorBo committed Nov 30, 2024
commit d4b269d33cffdbb6986bcf901855c3671c34245f
11 changes: 9 additions & 2 deletions src/coreclr/jit/helperexpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,8 +2392,15 @@ bool Compiler::fgLateCastExpansionForCall(BasicBlock** pBlock, Statement* stmt,
GenTree* cmp = rootNode->gtGetOp1();
if ((cmp->gtGetOp1() == call) && cmp->gtGetOp2()->IsIntegralConst(0))
{
castSucceedsFinalBb = cmp->OperIs(GT_EQ) ? block->GetFalseTarget() : block->GetTrueTarget();
castFailsFinalBb = cmp->OperIs(GT_EQ) ? block->GetTrueTarget() : block->GetFalseTarget();
castSucceedsFinalBb = block->GetTrueTarget();
castFailsFinalBb = block->GetFalseTarget();

// Assume we deal with "helper != null" pattern by default, we'll swap the targets
// if it's actually "helper == null" or if we're going to return null on success.
if (cmp->OperIs(GT_EQ) != (typeCheckPassedAction == TypeCheckPassedAction::ReturnNull))
{
std::swap(castSucceedsFinalBb, castFailsFinalBb);
}
}
}
}
Expand Down
Loading