[cdac] Simplify usage of TestPlaceholderTarget in tests #109873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove subclasses - squash
…ntext for it squash - mark created
ghost
added
the
needs-area-label
elinor-fung
added
test-enhancement
|
Tagging subscribers to this area: @tommcdon |
This was referenced Nov 15, 2024
Open
AaronRobinsonMSFT
approved these changes
Nov 19, 2024
| @@ -13,6 +14,7 @@ internal class ExecutionManagerTestBuilder | |||
| { | |||
| public const ulong ExecutionManagerCodeRangeMapAddress = 0x000a_fff0; | |||
|
|
|||
| const bool UseFunclets = true; | |||
There was a problem hiding this comment.
Is this needed? A const bool seems odd to me. If this is important, let's add a comment what this is trying to capture.
There was a problem hiding this comment.
I'm missing why that is odd? It's just indicating that the test builder (currently) always specifies to use funclets and it is not configurable on the instance.
There was a problem hiding this comment.
I'll move it to something local in a follow-up,.
src/native/managed/cdacreader/tests/MockDescriptors/MockDescriptors.HashMap.cs
Outdated
Show resolved
Hide resolved
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
- Make `TestPlaceholderTarget` (mock target) constructor take type infos and global values - Handle reading of global values in mock target implementation - Use Moq for creating a `ContractRegistry` instead of our own explicit implementation - Remove subclasses of `TestPlaceholderTarget`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPlaceholderTarget(mock target) constructor take type infos and global valuesContractRegistryinstead of our own explicit implementationTestPlaceholderTarget