Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: fix superpmi for new method getMethodInstantiationArgument #109321

Merged

Conversation

AndyAyersMS
Copy link
Member

Implementation was copied from getTypeInstantiationArgument but not fully updated.

Implementation was copied from getTypeInstantiationArgument but not
fully updated.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 29, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member Author

This mistake lead to a bunch of clean replay failures in an ASP.NET collection, so it indirectly shows the new devirtualization is happening.

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

Need to wait for PR triggering to get fixed.

@AndyAyersMS AndyAyersMS reopened this Oct 29, 2024
@AndyAyersMS AndyAyersMS merged commit 8f8ac8e into dotnet:main Oct 29, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants