Skip to content

Conversation

deeprobin
Copy link
Contributor

This PR implements and fixes #95965.

  • Expose constructors
  • Add doc comments
  • Add new public API to ref assembly
  • Add tests for passing null and non-null parameters to the ctors

Potentially breaking change if somebody does reflection hacks:

  • Rename the previous internal parameter inner to innerException as defined in the approved API scheme.

Added APIs

namespace System.Net;

public partial class CookieException
{
    public CookieException(string? message);
    public CookieException(string? message, Exception? innerException);
 }

@ghost
Copy link

ghost commented Oct 18, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Oct 18, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 18, 2024
@deeprobin deeprobin marked this pull request as ready for review October 18, 2024 21:25
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

deeprobin and others added 2 commits October 21, 2024 20:15
@MihaZupan MihaZupan merged commit 670401f into dotnet:main Oct 22, 2024
80 of 83 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: public ctor for CookieException with string parameter
4 participants