[release/9.0] [mono] Fix alloca builder creation#108654
Merged
jeffschwMSFT merged 2 commits intorelease/9.0from Oct 10, 2024
Merged
[release/9.0] [mono] Fix alloca builder creation#108654jeffschwMSFT merged 2 commits intorelease/9.0from
jeffschwMSFT merged 2 commits intorelease/9.0from
Conversation
This was hitting assert with debug version of llvm
github-actions
bot
requested review from
fanyang-mono and
steveisok
as code owners
ghost
added
the
Contributor
|
Tagging subscribers to this area: @lambdageek, @steveisok |
lambdageek
approved these changes
Oct 8, 2024
lewing
approved these changes
Oct 10, 2024
Member
|
@lewing can we get a customer impact included in the template? |
leecow
added
Servicing-approved
This was referenced Oct 10, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107464 to release/9.0
/cc @radekdoulik
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
It was found during porting to llvm 19.1.0, where the newer llvm has more asserts in place.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.