-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build error #108633
base: main
Are you sure you want to change the base?
Fixed build error #108633
Conversation
What's the compiler and version that you are using to build that is missing |
In addition, no error occurred in version 14.1.0. |
@am11 Could you please take a look? |
@JongHeonChoi, I am having hard time understanding how is it failing? It was moved here: runtime/src/native/minipal/utils.h Lines 12 to 13 in 43295bb
runtime/src/coreclr/pal/inc/pal.h Line 88 in dd91282
We were using gcc 8.4 on illumos until recently (now switched to 13), so I know that this is a known requirement for gcc < v10 on all platforms. Can you check why minipal/utils.h not making a difference? |
@am11 |
I suggest we close this PR and backport a9d74ac to release/8.0-staging bracnh. |
I added
But how can I find |
https://github.com/dotnet/runtime/blob/release/8.0-staging/src/native/minipal/utils.h do you not have this file in your branch? |
The |
For main branch, this is a dead code. I have cherry-picked a9d74ac on release/8.0-staging and there is no error. i.e. |
A build error occurred in Tizen OS as below.
Fix illumos-x64 build #85006
-> The location of the code has been changed.
Unify hardware feature detection between CoreCLR JIT and AOT #89342
-> The code has been deleted.
So I restore the code again.
I think it should be applied to
release/8.0-staging
branch as well.