Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix IndexOf Optimization Code #108562

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2024

Backport of #108499 to release/9.0

/cc @tarekgh

Customer Impact

  • Customer reported
  • Found internally

Users can run into inconsistent results when calling String.IndexOf(...) which can cause some failure in apps. The issue #108424 describes the problem. This is reported and escalated by Teams CMD OPEX team. We have provided some workaround, but it is not perfect as it may cause some side effects depending on the scenario the workaround is used with.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Manually tested all failure cases, added more tests to cover the failing cases, and passed all regression tests.

Risk

Low, we have added extra condition to check for the failing case before IndexOf operation return negative result. No other logic has changed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added the Servicing-consider Issue for next servicing release review label Oct 4, 2024
@tarekgh tarekgh added this to the 9.0.0 milestone Oct 4, 2024
@tarekgh
Copy link
Member

tarekgh commented Oct 6, 2024

/ba-g dotnet-linker-test is not analyzed by the CI.

@tarekgh tarekgh added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 6, 2024
@tarekgh
Copy link
Member

tarekgh commented Oct 6, 2024

This is approved by email.

@ericstj ericstj merged commit 09393c2 into release/9.0 Oct 7, 2024
147 of 153 checks passed
@jkotas jkotas deleted the backport/pr-108499-to-release/9.0 branch October 10, 2024 07:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants