Update fuzzing infra to build and use the shared framework #108555
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
buyaa-n
added
area-Meta
and removed
needs-area-label
|
The bot's also working again now MihuBot/runtime-utils@5466698 |
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Update deploy-to-onefuzz pipeline
| flAllocationType: VirtualAllocAllocationType.MEM_RESERVE | VirtualAllocAllocationType.MEM_COMMIT, | ||
| flProtect: VirtualAllocProtection.PAGE_NOACCESS); | ||
| VirtualAllocHandle handle; | ||
| checked |
There was a problem hiding this comment.
Was this checked added due to a bug? It seems like it would only throw on 32-bit platforms.
There was a problem hiding this comment.
Not due to a bug, after changing the project build with current runtime settings many analyzer diagnostics found that are fixed or suppressed with the PR.
CA2020 Starting with .NET 7 the explicit conversion '(IntPtr)Int64' will not throw when overflowing in an unchecked context. Wrap the expression with a 'checked' statement to restore the .NET 6 behavior.
Flagged at row 38: dwSize: (IntPtr)totalBytesToAllocate /* cast throws OverflowException if out of range */,
Given that this type is for testing, and also base on the comment I assumed it is important to restore the overflowing behavior
There was a problem hiding this comment.
I suppressed have all other warnings for this BoundedMemory type, now after moving <IsTestSupportProject>true</IsTestSupportProject> property above importing parent Directory.Build.props this type is not being analyzed anymore, same as all other test types. I can revert this and other suppressions with my other PR
| dotnet build | ||
| ``` | ||
|
|
||
| Now you can run `run.bat`, which will create separate directories for each fuzzing target, instrument the relevant assemblies, and generate a helper script for running them locally. |
There was a problem hiding this comment.
nit: "Now you can" and "You can now" a little below seems unnecessary.
There was a problem hiding this comment.
I can update with my other PR
…8555) * Update fuzzing infra to build and use the shared framework * Update deploy-to-onefuzz pipeline * Apply suggestions from code review Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com> --------- Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Fuzzing infra is currently broken because of #106599, because it is partially integrated with the repo workflow. In order to fix this failure, we need to integrate it completely, that means need to fix #107204:
nuget.configas it became same as the repo config in the root, also removedDirectory.Build.targetsthat was emptyFurther
MihuBotneed to be updated as needed, might also need to updateonefuzzdeployment scripts CC @MihaZupan