Fix LINQ Last() in ConcatNIterator to also check base case (Concat2Iterator) #108486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Oct 2, 2024
rameel
reviewed
Oct 3, 2024
jeffhandley
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Thank you, @andrewjsaid!
This looks good to me, but I'd like @krwq or @eiriktsarpalis to review as well before merge. Once the fix is merged, we'll backport this to .NET 9 as well.
|
@andrewjsaid thanks for the contribution! Have you perhaps checked if other APIs in the speed optimizations might have similar issues? (i.e. TryGetFirst or similar) |
|
@krwq You're welcome. Yes I did check and it looks like |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11239355958 |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108477
ConcatNIterator.PreviousNreturnsnullin the base case as_tailisConcat2Iterator. I've copied theConcatNIterator<TSource>? node, previousN = this;pattern used in other methods over to here and added test cases