[release/9.0] [wasm] Include browser targets if RID is not wasi-wasm#108434
Merged
jeffschwMSFT merged 3 commits intorelease/9.0from Oct 11, 2024
Merged
[release/9.0] [wasm] Include browser targets if RID is not wasi-wasm#108434jeffschwMSFT merged 3 commits intorelease/9.0from
jeffschwMSFT merged 3 commits intorelease/9.0from
Conversation
github-actions
bot
requested review from
akoeplinger and
lewing
as code owners
ghost
added
the
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
ilonatommy
approved these changes
Oct 1, 2024
This was referenced Oct 1, 2024
Member
|
removing servicing consider label until there is a template filled in |
jeffschwMSFT
removed
the
Servicing-consider
Member
|
@jeffschwMSFT I have forget to remove template placeholder from first paragraph, otherwise the template is filled. Should I put more details in there? |
Member
|
thanks @maraf , can you elaborate on how the fix addresses the issue? I will approve and we can send in email for approval |
jeffschwMSFT
approved these changes
Oct 9, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9 GA
jeffschwMSFT
added
Servicing-consider
Member
|
please take a look at the pr failures. |
Member
|
All green now |
This was referenced Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108283 to release/9.0
/cc @maraf
Customer Impact
When publishing blazor app to azure containers, the VS wizard generates
linux-x64RID by default (wizard for publishing to folder correctly picksbrowser-wasmRID).This PR makes the browser targets included any time when RID is not
wasi-wasm, instead of relying on RID beingbrowser-wasm.Regression
The regression was introduced in #102806, where we started use Wasm SDK also for wasi targets and so we started to include browser targets only when RID is
browser-wasm.Testing
Manual test scenario.
Risk
Low. We have semantically reverted to previous behavior (include browser targets all the time with the exception for wasi).