-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ReflectionInvocation.CanValueSpecialCast()
to managed
#108305
Merged
AaronRobinsonMSFT
merged 8 commits into
dotnet:main
from
AaronRobinsonMSFT:hmf_CanValueSpecialCast
Sep 28, 2024
Merged
Convert ReflectionInvocation.CanValueSpecialCast()
to managed
#108305
AaronRobinsonMSFT
merged 8 commits into
dotnet:main
from
AaronRobinsonMSFT:hmf_CanValueSpecialCast
Sep 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
changed the title
Convert
Convert Sep 26, 2024
ReflectionInvocation.CanValueSpecialCast()
managedReflectionInvocation.CanValueSpecialCast()
to managed
lambdageek
approved these changes
Sep 26, 2024
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
jkotas
reviewed
Sep 27, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 27, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 27, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 27, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
3 tasks
huoyaoyuan
reviewed
Sep 27, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 27, 2024
jkotas
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo build breaks)
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…et#108305) --------- Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.